Remove BaseSession::SignalNewDescription. It was only used by GTP and now just clutters the code.

webrtc/p2p/base/session.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 564 matching lines @@
 }
 
 void BaseSession::SetState(State state) {
   ASSERT(signaling_thread_->IsCurrent());
   if (state != state_) {
     LogState(state_, state);
     state_ = state;
     SignalState(this, state_);
     signaling_thread_->Post(this, MSG_STATE);
   }
-  SignalNewDescription();
 }
 
 void BaseSession::SetError(Error error, const std::string& error_desc) {
   ASSERT(signaling_thread_->IsCurrent());
   if (error != error_) {
     error_ = error;
     error_desc_ = error_desc;
     SignalError(this, error);
   }
 }
@@ skipping 184 matching lines @@
   }
   const TransportInfo* transport_info =
       description->GetTransportInfoByName(content_name);
   if (!transport_info) {
     return false;
   }
   *tdesc = transport_info->description;
   return true;
 }
 
-void BaseSession::SignalNewDescription() {
-  ContentAction action;
-  ContentSource source;
-  if (!GetContentAction(&action, &source)) {
-    return;
-  }
-  if (source == CS_LOCAL) {
-    SignalNewLocalDescription(this, action);
-  } else {
-    SignalNewRemoteDescription(this, action);
-  }
-}
-
-bool BaseSession::GetContentAction(ContentAction* action,
-                                   ContentSource* source) {
-  switch (state_) {
-    // new local description
-    case STATE_SENTINITIATE:
-      *action = CA_OFFER;
-      *source = CS_LOCAL;
-      break;
-    case STATE_SENTPRACCEPT:
-      *action = CA_PRANSWER;
-      *source = CS_LOCAL;
-      break;
-    case STATE_SENTACCEPT:
-      *action = CA_ANSWER;
-      *source = CS_LOCAL;
-      break;
-    // new remote description
-    case STATE_RECEIVEDINITIATE:
-      *action = CA_OFFER;
-      *source = CS_REMOTE;
-      break;
-    case STATE_RECEIVEDPRACCEPT:
-      *action = CA_PRANSWER;
-      *source = CS_REMOTE;
-      break;
-    case STATE_RECEIVEDACCEPT:
-      *action = CA_ANSWER;
-      *source = CS_REMOTE;
-      break;
-    default:
-      return false;
-  }
-  return true;
-}
-
 void BaseSession::OnMessage(rtc::Message *pmsg) {
   switch (pmsg->message_id) {
   case MSG_TIMEOUT:
     // Session timeout has occured.
     SetError(ERROR_TIME, "Session timeout has occured.");
     break;
 
   case MSG_STATE:
     switch (state_) {
     case STATE_SENTACCEPT:
     case STATE_RECEIVEDACCEPT:
       SetState(STATE_INPROGRESS);
       break;
 
     default:
       // Explicitly ignoring some states here.
       break;
     }
     break;
   }
 }
 
 }  // namespace cricket