Update audio code to use size_t more correctly,

Update audio code to use size_t more correctly,
webrtc/modules/audio_coding/codecs/ portion.

This is a piece of https://codereview.webrtc.org/1230503003 , split out to a
separate change to make reviewing easier.

BUG=chromium:81439
TEST=none

[Peter Kasting, 2015-07-23 19:12:11]

pkasting@chromium.org changed reviewers:
+ kwiberg@webrtc.org

[Peter Kasting, 2015-07-27 23:41:59]

pkasting@chromium.org changed reviewers:
+ minyue@webrtc.org, turaj@webrtc.org
- kwiberg@webrtc.org

[Peter Kasting, 2015-07-27 23:42:44]

pkasting@chromium.org changed reviewers:
- turaj@webrtc.org

[Peter Kasting, 2015-07-27 23:43:30]

Changing reviewer to minyue in hopes of finding someone who is not on vacation
to review.

[Peter Kasting, 2015-07-27 23:43:35]

Changing reviewer to minyue in hopes of finding someone who is not on vacation
to review.

[kwiberg-webrtc, 2015-08-06 09:14:24]

kwiberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2015-08-06 09:14:25]

lgtm

https://codereview.webrtc.org/1225173002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc (right):

https://codereview.webrtc.org/1225173002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc:199: // iteration.
Not sure the comment says anything that isn't already obvious, but since you
bothered to write it I guess I'm wrong. :-)

https://codereview.webrtc.org/1225173002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc
(right):

https://codereview.webrtc.org/1225173002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc:69:
EXPECT_CALL(mock_encoder_, Max10MsFramesInAPacket()).WillOnce(Return(1U));
1u is a tiny bit easier to read.

[Peter Kasting, 2015-08-06 18:38:50]

New snap not yet up, will fix the below issue and upload later (am WFH today)

https://codereview.webrtc.org/1225173002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc (right):

https://codereview.webrtc.org/1225173002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc:199: // iteration.
On 2015/08/06 09:14:25, kwiberg-webrtc wrote:
> Not sure the comment says anything that isn't already obvious, but since you
> bothered to write it I guess I'm wrong. :-)

I wrote it because I did the wrong thing here originally, got bitten by test
failures as a result, and required a couple hours to track down the actual bug
:P

https://codereview.webrtc.org/1225173002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc
(right):

https://codereview.webrtc.org/1225173002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc:69:
EXPECT_CALL(mock_encoder_, Max10MsFramesInAPacket()).WillOnce(Return(1U));
On 2015/08/06 09:14:25, kwiberg-webrtc wrote:
> 1u is a tiny bit easier to read.

OK

[Peter Kasting, 2015-08-07 18:16:14]

(Updated, FYI, no reply needed)

[hlundin-webrtc, 2015-08-10 11:27:27]

Drive-by on first file.

https://codereview.webrtc.org/1225173002/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/audio_decoder.h (right):

https://codereview.webrtc.org/1225173002/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/audio_decoder.h:65: virtual size_t
DecodePlc(size_t num_frames, int16_t* decoded);
I think we should still be able to return a negative value to signal an error.

[minyue-webrtc, 2015-08-10 13:02:25]

https://codereview.webrtc.org/1225173002/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/audio_decoder.h (right):

https://codereview.webrtc.org/1225173002/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/audio_decoder.h:65: virtual size_t
DecodePlc(size_t num_frames, int16_t* decoded);
On 2015/08/10 11:27:27, hlundin-webrtc wrote:
> I think we should still be able to return a negative value to signal an error.

See some discussion here
https://codereview.webrtc.org/1228793004/diff/20001/webrtc/modules/audio_codi...

[hlundin-webrtc, 2015-08-10 13:12:36]

henrik.lundin@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2015-08-10 13:12:36]

https://codereview.webrtc.org/1225173002/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/audio_decoder.h (right):

https://codereview.webrtc.org/1225173002/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/audio_decoder.h:65: virtual size_t
DecodePlc(size_t num_frames, int16_t* decoded);
On 2015/08/10 13:02:24, minyue-webrtc wrote:
> On 2015/08/10 11:27:27, hlundin-webrtc wrote:
> > I think we should still be able to return a negative value to signal an
error.
> 
> See some discussion here
>
https://codereview.webrtc.org/1228793004/diff/20001/webrtc/modules/audio_codi...

Hmm, yes, I guess I agree. It's just that I am slightly annoyed by the asymmetry
between DecodePlc and the other Decode functions. Oh, well, I'll yield.