webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc - Issue 1225173002: Update audio code to use size_t more correctly,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc

Issue 1225173002: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/audio_decoder.h ('K') | « webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc ('k') | webrtc/modules/audio_coding/codecs/tools/audio_codec_speed_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc

diff --git a/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc b/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc

index 4debdfab8d3807e22daf060c79680fae46f652b0..a1ddf4b24c2afdbdc70483e9b87fc8df938a7f6e 100644

--- a/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc

+++ b/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc

@@ -113,13 +113,13 @@ TEST_F(AudioEncoderCopyRedTest, CheckNumChannelsPropagation) {

}

TEST_F(AudioEncoderCopyRedTest, CheckFrameSizePropagation) {

- EXPECT_CALL(mock_encoder_, Num10MsFramesInNextPacket()).WillOnce(Return(17));

- EXPECT_EQ(17, red_->Num10MsFramesInNextPacket());

+ EXPECT_CALL(mock_encoder_, Num10MsFramesInNextPacket()).WillOnce(Return(17U));

+ EXPECT_EQ(17U, red_->Num10MsFramesInNextPacket());

}

TEST_F(AudioEncoderCopyRedTest, CheckMaxFrameSizePropagation) {

- EXPECT_CALL(mock_encoder_, Max10MsFramesInAPacket()).WillOnce(Return(17));

- EXPECT_EQ(17, red_->Max10MsFramesInAPacket());

+ EXPECT_CALL(mock_encoder_, Max10MsFramesInAPacket()).WillOnce(Return(17U));

+ EXPECT_EQ(17U, red_->Max10MsFramesInAPacket());

}

TEST_F(AudioEncoderCopyRedTest, CheckSetBitratePropagation) {