Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: webrtc/modules/audio_coding/codecs/audio_decoder.h

Issue 1225173002: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/codecs/audio_decoder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 int sample_rate_hz, 55 int sample_rate_hz,
56 size_t max_decoded_bytes, 56 size_t max_decoded_bytes,
57 int16_t* decoded, 57 int16_t* decoded,
58 SpeechType* speech_type); 58 SpeechType* speech_type);
59 59
60 // Indicates if the decoder implements the DecodePlc method. 60 // Indicates if the decoder implements the DecodePlc method.
61 virtual bool HasDecodePlc() const; 61 virtual bool HasDecodePlc() const;
62 62
63 // Calls the packet-loss concealment of the decoder to update the state after 63 // Calls the packet-loss concealment of the decoder to update the state after
64 // one or several lost packets. 64 // one or several lost packets.
65 virtual int DecodePlc(int num_frames, int16_t* decoded); 65 virtual size_t DecodePlc(size_t num_frames, int16_t* decoded);
hlundin-webrtc 2015/08/10 11:27:27 I think we should still be able to return a negati
minyue-webrtc 2015/08/10 13:02:24 See some discussion here https://codereview.webrtc
hlundin-webrtc 2015/08/10 13:12:36 Hmm, yes, I guess I agree. It's just that I am sli
66 66
67 // Initializes the decoder. 67 // Initializes the decoder.
68 virtual int Init() = 0; 68 virtual int Init() = 0;
69 69
70 // Notifies the decoder of an incoming packet to NetEQ. 70 // Notifies the decoder of an incoming packet to NetEQ.
71 virtual int IncomingPacket(const uint8_t* payload, 71 virtual int IncomingPacket(const uint8_t* payload,
72 size_t payload_len, 72 size_t payload_len,
73 uint16_t rtp_sequence_number, 73 uint16_t rtp_sequence_number,
74 uint32_t rtp_timestamp, 74 uint32_t rtp_timestamp,
75 uint32_t arrival_timestamp); 75 uint32_t arrival_timestamp);
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 int sample_rate_hz, 113 int sample_rate_hz,
114 int16_t* decoded, 114 int16_t* decoded,
115 SpeechType* speech_type); 115 SpeechType* speech_type);
116 116
117 private: 117 private:
118 DISALLOW_COPY_AND_ASSIGN(AudioDecoder); 118 DISALLOW_COPY_AND_ASSIGN(AudioDecoder);
119 }; 119 };
120 120
121 } // namespace webrtc 121 } // namespace webrtc
122 #endif // WEBRTC_MODULES_AUDIO_CODING_NETEQ_INTERFACE_AUDIO_DECODER_H_ 122 #endif // WEBRTC_MODULES_AUDIO_CODING_NETEQ_INTERFACE_AUDIO_DECODER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/codecs/audio_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698