Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1220863002: Fail RTP parsing on excessive padding length. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fail RTP parsing on excessive padding length. BUG=webrtc:4771 R=stefan@webrtc.org Committed: https://crrev.com/bd2522abf75891f34da6f83c247c47ca95641cee Cr-Commit-Position: refs/heads/master@{#9525}

Patch Set 1 #

Patch Set 2 : make DCHECK #

Patch Set 3 : remove padding bit from TruncatedPacketWithFBitSetEndingAfterFirstRedHeader #

Patch Set 4 : with size prints for tryjob #

Patch Set 5 : lol bug #

Patch Set 6 : fix rampup test and account for padding in RestoreOriginalPacket #

Total comments: 1

Patch Set 7 : move paddingLength to + side #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 4 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video/rampup_tests.cc View 1 2 3 4 5 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (9 generated)
pbos-webrtc
PTAL. Also I couldn't find any place where RtpHeaderParser is unittested. Do you know if ...
5 years, 5 months ago (2015-06-30 12:06:22 UTC) #1
pbos-webrtc
make DCHECK
5 years, 5 months ago (2015-06-30 12:07:22 UTC) #2
stefan-webrtc
lgtm
5 years, 5 months ago (2015-06-30 13:09:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220863002/20001
5 years, 5 months ago (2015-06-30 13:12:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/8155)
5 years, 5 months ago (2015-06-30 13:23:49 UTC) #7
pbos-webrtc
remove padding bit from TruncatedPacketWithFBitSetEndingAfterFirstRedHeader
5 years, 5 months ago (2015-06-30 14:25:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220863002/40001
5 years, 5 months ago (2015-06-30 14:26:15 UTC) #11
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-06-30 14:43:55 UTC) #13
pbos-webrtc
with size prints for tryjob
5 years, 5 months ago (2015-06-30 15:30:47 UTC) #14
pbos-webrtc
lol bug
5 years, 5 months ago (2015-07-01 11:12:00 UTC) #15
pbos-webrtc
fix rampup test and account for padding in RestoreOriginalPacket
5 years, 5 months ago (2015-07-01 11:28:27 UTC) #16
pbos-webrtc
PTAL
5 years, 5 months ago (2015-07-01 11:28:49 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220863002/100001
5 years, 5 months ago (2015-07-01 11:29:11 UTC) #20
stefan-webrtc
lgtm https://codereview.webrtc.org/1220863002/diff/100001/webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc File webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc (right): https://codereview.webrtc.org/1220863002/diff/100001/webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc#newcode241 webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc:241: *packet_length - header.paddingLength) { Move header.paddingLength to other ...
5 years, 5 months ago (2015-07-01 11:38:17 UTC) #21
pbos-webrtc
move paddingLength to + side
5 years, 5 months ago (2015-07-01 11:38:31 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220863002/120001
5 years, 5 months ago (2015-07-01 11:39:05 UTC) #25
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 5 months ago (2015-07-01 12:35:57 UTC) #26
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 12:36:06 UTC) #27
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/bd2522abf75891f34da6f83c247c47ca95641cee
Cr-Commit-Position: refs/heads/master@{#9525}

Powered by Google App Engine
This is Rietveld 408576698