webrtc/modules/rtp_rtcp/source/rtp_utility.cc - Issue 1220863002: Fail RTP parsing on excessive padding length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_utility.cc

Issue 1220863002: Fail RTP parsing on excessive padding length. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: move paddingLength to + side Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_utility.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_utility.cc b/webrtc/modules/rtp_rtcp/source/rtp_utility.cc

index 3fef05355c701d7235b546b520220cd99d0bddff..0d083bd92a5289f5c4e940c40a0eea096c01190e 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_utility.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_utility.cc

@@ -355,6 +355,8 @@ bool RtpHeaderParser::Parse(RTPHeader& header,

}

header.headerLength += XLen;

}

+ if (header.headerLength + header.paddingLength > static_cast<size_t>(length))

+ return false;

return true;

}

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc ('k') | webrtc/video/rampup_tests.cc » ('j') | no next file with comments »