webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc - Issue 1220863002: Fail RTP parsing on excessive padding length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

Issue 1220863002: Fail RTP parsing on excessive padding length. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: move paddingLength to + side Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc b/webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

index 8d8147cd63820a21a00b9e732542394985b53cec..ff64e49cafa482b4882d6c8f84e662b4a821165d 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc

@@ -13,6 +13,7 @@

#include <assert.h>

#include <string.h>

+#include "webrtc/base/checks.h"

#include "webrtc/modules/rtp_rtcp/interface/rtp_cvo.h"

#include "webrtc/modules/rtp_rtcp/interface/rtp_payload_registry.h"

#include "webrtc/modules/rtp_rtcp/source/rtp_format.h"

@@ -60,6 +61,7 @@ int32_t RTPReceiverVideo::ParseRtpPacket(WebRtcRTPHeader* rtp_header,

rtp_header->header.timestamp);

rtp_header->type.Video.codec = specific_payload.Video.videoCodecType;

+ DCHECK_GE(payload_length, rtp_header->header.paddingLength);

const size_t payload_data_length =

payload_length - rtp_header->header.paddingLength;