Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1192863006: Revert "Pull the Voice Activity Detector out from the AGC" (Closed)

Created:
5 years, 6 months ago by aluebs-webrtc
Modified:
5 years, 6 months ago
Reviewers:
niklas.enbom
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Pull the Voice Activity Detector out from the AGC" This reverts commit 34be126c1b3ee60ecdb86b1de41a0648347450b2. It breaks Chromium ASAN. TBR=niklas.enbom@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/f260fc21360ac5f599e64ce9ea2ea616909eca44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -2744 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 3 chunks +18 lines, -20 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc.h View 2 chunks +15 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc.cc View 5 chunks +67 lines, -10 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/agc_audio_proc.h View 4 chunks +8 lines, -9 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/agc_audio_proc.cc View 12 chunks +38 lines, -43 lines 0 comments Download
A webrtc/modules/audio_processing/agc/agc_audio_proc_internal.h View 1 chunk +81 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/agc_audio_proc_unittest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc_manager_direct.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/agc/circular_buffer.h View 4 chunks +7 lines, -7 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/circular_buffer.cc View 6 chunks +15 lines, -17 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/circular_buffer_unittest.cc View 8 chunks +20 lines, -21 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/common.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/gmm.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/gmm.cc View 3 chunks +5 lines, -8 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/gmm_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A webrtc/modules/audio_processing/agc/noise_gmm_tables.h View 1 chunk +77 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/pitch_based_vad.h View 3 chunks +7 lines, -8 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/pitch_based_vad.cc View 4 chunks +9 lines, -11 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/pitch_based_vad_unittest.cc View 2 chunks +11 lines, -15 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/pitch_internal.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/pitch_internal.cc View 2 chunks +2 lines, -1 line 0 comments Download
A + webrtc/modules/audio_processing/agc/pitch_internal_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/pole_zero_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/pole_zero_filter.cc View 5 chunks +16 lines, -11 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/pole_zero_filter_unittest.cc View 1 chunk +23 lines, -28 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/standalone_vad.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_processing/agc/standalone_vad.cc View 3 chunks +6 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_processing/agc/standalone_vad_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A webrtc/modules/audio_processing/agc/voice_gmm_tables.h View 1 chunk +77 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 3 chunks +18 lines, -20 lines 0 comments Download
D webrtc/modules/audio_processing/vad/common.h View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/modules/audio_processing/vad/gmm.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/modules/audio_processing/vad/gmm.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D webrtc/modules/audio_processing/vad/gmm_unittest.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/modules/audio_processing/vad/noise_gmm_tables.h View 1 chunk +0 lines, -85 lines 0 comments Download
D webrtc/modules/audio_processing/vad/pitch_based_vad.h View 1 chunk +0 lines, -57 lines 0 comments Download
D webrtc/modules/audio_processing/vad/pitch_based_vad.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D webrtc/modules/audio_processing/vad/pitch_based_vad_unittest.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D webrtc/modules/audio_processing/vad/pitch_internal.h View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/modules/audio_processing/vad/pitch_internal.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D webrtc/modules/audio_processing/vad/pitch_internal_unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/modules/audio_processing/vad/pole_zero_filter.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/modules/audio_processing/vad/pole_zero_filter.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D webrtc/modules/audio_processing/vad/pole_zero_filter_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D webrtc/modules/audio_processing/vad/standalone_vad.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/modules/audio_processing/vad/standalone_vad.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D webrtc/modules/audio_processing/vad/standalone_vad_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D webrtc/modules/audio_processing/vad/vad_audio_proc.h View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/modules/audio_processing/vad/vad_audio_proc.cc View 1 chunk +0 lines, -274 lines 0 comments Download
D webrtc/modules/audio_processing/vad/vad_audio_proc_internal.h View 1 chunk +0 lines, -94 lines 0 comments Download
D webrtc/modules/audio_processing/vad/vad_audio_proc_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/modules/audio_processing/vad/vad_circular_buffer.h View 1 chunk +0 lines, -69 lines 0 comments Download
D webrtc/modules/audio_processing/vad/vad_circular_buffer.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D webrtc/modules/audio_processing/vad/vad_circular_buffer_unittest.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D webrtc/modules/audio_processing/vad/voice_activity_detector.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/modules/audio_processing/vad/voice_activity_detector.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D webrtc/modules/audio_processing/vad/voice_activity_detector_unittest.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D webrtc/modules/audio_processing/vad/voice_gmm_tables.h View 1 chunk +0 lines, -85 lines 0 comments Download
M webrtc/modules/modules.gyp View 2 chunks +7 lines, -8 lines 0 comments Download
M webrtc/tools/agc/activity_metric.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
aluebs-webrtc
5 years, 6 months ago (2015-06-19 18:24:07 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f260fc21360ac5f599e64ce9ea2ea616909eca44.

Powered by Google App Engine
This is Rietveld 408576698