Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1187033005: Revert of Allow intelligibility to compile in apm (Closed)

Created:
5 years, 6 months ago by aluebs-webrtc
Modified:
5 years, 6 months ago
Reviewers:
ekm
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Allow intelligibility to compile in apm (patchset #1 id:1 of https://codereview.webrtc.org/1182323005/) Reason for revert: Breaking the build bots: http://build.chromium.org/p/client.webrtc/builders/Mac32%20Release%20%5Blarge%20tests%5D/builds/4544 Fails to compile with this error: ../../webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.cc:218:25: error: no member named 'accumulate' in namespace 'std' power_target = std::accumulate(clear_variance_.variance(), Original issue's description: > Allow intelligibility to compile in apm > > - Added files to gyp and BUILD > - Made minor fixes to get everything to compile > and intelligibility_proc to run > - Added comments > - Auto-reformatting > > Original cl is at: https://webrtc-codereview.appspot.com/57579004/ > > TBR=aluebs@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/b7553dfdbb1ca7779eb0d80b5f509523c9b00086 TBR=ekmeyerson@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c555b99c13aa25cf891dd34602f1b620b3f33bfb Cr-Commit-Position: refs/heads/master@{#9455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -342 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_tests.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.h View 4 chunks +34 lines, -75 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.cc View 17 chunks +84 lines, -106 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_proc.cc View 7 chunks +40 lines, -74 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_utils.h View 5 chunks +22 lines, -22 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_utils.cc View 10 chunks +31 lines, -44 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aluebs-webrtc
Created Revert of Allow intelligibility to compile in apm
5 years, 6 months ago (2015-06-17 03:25:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187033005/1
5 years, 6 months ago (2015-06-17 03:26:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 03:26:20 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 03:26:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c555b99c13aa25cf891dd34602f1b620b3f33bfb
Cr-Commit-Position: refs/heads/master@{#9455}

Powered by Google App Engine
This is Rietveld 408576698