Change kEchoCancellation to be 'echoCancellation'.

Change kEchoCancellation to be 'echoCancellation'.
This is the second cl in WebRTC for this change and will be landed after Chromium has been updated to use kGooglEchoCancellation where that variant is required. See also the first part: https://codereview.webrtc.org/1179233003

BUG=webrtc:4747
R=andrew@webrtc.org

Committed: https://crrev.com/39b31001d2d74373f1e60cdbc8e57e402bdf34e3
Cr-Commit-Position: refs/heads/master@{#9490}

[Andrew MacDonald, 2015-06-15 04:04:14]

https://codereview.webrtc.org/1185963003/diff/1/talk/app/webrtc/mediaconstrai...
File talk/app/webrtc/mediaconstraintsinterface.h (right):

https://codereview.webrtc.org/1185963003/diff/1/talk/app/webrtc/mediaconstrai...
talk/app/webrtc/mediaconstraintsinterface.h:75: static const char
kEchoCancellation[];  // echoCancellation
Two concerns here:
1. IIUC, due to this code:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

"googEchoCancellation" will have no effect after your change. This would break
code such as this:
https://webrtc-codereview.appspot.com/53669004/diff/1/talk/examples/android/s...

which uses "googEchoCancellation", no?

2. Chromium treats "echoCancellation" as a flag to disable all audio processing:
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...

which I think is a useful interpretation. We should probably be consistent in
libjingle.

[tommi, 2015-06-15 06:25:33]

On 2015/06/15 at 04:04:14, andrew wrote:
>
https://codereview.webrtc.org/1185963003/diff/1/talk/app/webrtc/mediaconstrai...
> File talk/app/webrtc/mediaconstraintsinterface.h (right):
> 
>
https://codereview.webrtc.org/1185963003/diff/1/talk/app/webrtc/mediaconstrai...
> talk/app/webrtc/mediaconstraintsinterface.h:75: static const char
kEchoCancellation[];  // echoCancellation
> Two concerns here:
> 1. IIUC, due to this code:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...
> 
> "googEchoCancellation" will have no effect after your change. This would break
code such as this:
>
https://webrtc-codereview.appspot.com/53669004/diff/1/talk/examples/android/s...
> 
> which uses "googEchoCancellation", no?
> 
> 2. Chromium treats "echoCancellation" as a flag to disable all audio
processing:
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...
> 
> which I think is a useful interpretation. We should probably be consistent in
libjingle.

Did you miss the other two changelists perhaps?

[Andrew MacDonald, 2015-06-15 06:56:40]

On 2015/06/15 at 06:25:33, tommi wrote:
> Did you miss the other two changelists perhaps?

Ah, sorry, I managed to confuse myself. I see what you're doing now :)

[Andrew MacDonald, 2015-06-15 06:57:40]

lgtm

[tommi, 2015-06-15 08:37:46]

Rebase

[tommi, 2015-06-23 15:07:17]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2015-06-23 15:07:18]

The patchset sent to the CQ was uploaded after l-g-t-m from andrew@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1185963003/#ps20001 (title:
"Rebase")

[commit-bot: I haz the power, 2015-06-23 15:07:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1185963003/20001

[commit-bot: I haz the power, 2015-06-23 16:50:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-23 16:50:57]

Patchset 2 (id:??) landed as
https://crrev.com/39b31001d2d74373f1e60cdbc8e57e402bdf34e3
Cr-Commit-Position: refs/heads/master@{#9490}