Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: talk/app/webrtc/mediaconstraintsinterface.h

Issue 1185963003: Change kEchoCancellation to be 'echoCancellation'. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@constraint
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/mediaconstraintsinterface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/mediaconstraintsinterface.h
diff --git a/talk/app/webrtc/mediaconstraintsinterface.h b/talk/app/webrtc/mediaconstraintsinterface.h
index 843bee071c44835a7c42de855eb5ca166c810dd4..469a3d3f2d3beb2369d7236d82eb95dd33cc0a74 100644
--- a/talk/app/webrtc/mediaconstraintsinterface.h
+++ b/talk/app/webrtc/mediaconstraintsinterface.h
@@ -72,12 +72,9 @@ class MediaConstraintsInterface {
static const char kMinFrameRate[]; // minFrameRate
// Constraint keys used by a local audio source.
+ static const char kEchoCancellation[]; // echoCancellation
+
// These keys are google specific.
- // TODO(tommi): Change kEchoCancellation to be "echoCancellation" once
- // Chrome has been updated to use kGoogEchoCancellation where the 'goog'
- // variant is needed.
- // See https://code.google.com/p/webrtc/issues/detail?id=4747
- static const char kEchoCancellation[]; // googEchoCancellation
static const char kGoogEchoCancellation[]; // googEchoCancellation
// TODO(henrik.lundin) Remove kExperimentalEchoCancellation.
« no previous file with comments | « no previous file | talk/app/webrtc/mediaconstraintsinterface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698