Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 3019433002: Remove VoECodec (Closed)

Created:
3 years, 3 months ago by the sun
Modified:
3 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoECodec. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/3019433002 Cr-Commit-Position: refs/heads/master@{#19889} Committed: https://webrtc.googlesource.com/src/+/6dc2038d0d6b0bd48d4789024857508a761ef4fc

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1026 lines) Patch
M media/engine/webrtcvoe.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M test/mock_voice_engine.h View 1 2 3 1 chunk +0 lines, -21 lines 0 comments Download
M voice_engine/BUILD.gn View 1 2 3 3 chunks +0 lines, -4 lines 0 comments Download
M voice_engine/channel.h View 1 2 3 3 chunks +1 line, -13 lines 0 comments Download
M voice_engine/channel.cc View 1 2 3 4 chunks +1 line, -250 lines 0 comments Download
M voice_engine/channel_proxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M voice_engine/channel_proxy.cc View 2 chunks +0 lines, -12 lines 0 comments Download
D voice_engine/include/voe_codec.h View 1 chunk +0 lines, -147 lines 0 comments Download
D voice_engine/voe_codec_impl.h View 1 chunk +0 lines, -73 lines 0 comments Download
D voice_engine/voe_codec_impl.cc View 1 chunk +0 lines, -391 lines 0 comments Download
D voice_engine/voe_codec_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M voice_engine/voice_engine_impl.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
the sun
3 years, 3 months ago (2017-09-18 11:13:34 UTC) #3
kwiberg-webrtc
lgtm!
3 years, 3 months ago (2017-09-18 11:16:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3019433002/60001
3 years, 3 months ago (2017-09-18 11:36:06 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-18 12:22:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://webrtc.googlesource.com/src/+/6dc2038d0d6b0bd48d4789024857508a761ef4fc

Powered by Google App Engine
This is Rietveld 408576698