Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 3018563002: Remove Linux MSR power monitoring code (Closed)

Created:
3 years, 3 months ago by charliea (OOO until 10-5)
Modified:
3 years, 3 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Remove Linux MSR power monitoring code This code has been made obsolete with BattOr-based power monitoring. (Realistically, we had no Linux laptops on the waterfall anyhow, so if they were measuring anything, it wasn't very meaningful.) R=nednguyen@google.com BUG=chromium:763263 Review-Url: https://chromiumcodereview.appspot.com/3018563002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5626d32b69f2ca920d8f9380f3a35942e277b75d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -50 lines) Patch
M telemetry/telemetry/internal/platform/linux_platform_backend.py View 3 chunks +1 line, -24 lines 0 comments Download
M telemetry/telemetry/internal/platform/power_monitor/msr_power_monitor.py View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
charliea (OOO until 10-5)
3 years, 3 months ago (2017-09-19 19:44:09 UTC) #2
nednguyen
lgtm
3 years, 3 months ago (2017-09-19 19:50:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3018563002/1
3 years, 3 months ago (2017-09-19 20:27:28 UTC) #10
commit-bot: I haz the power
3 years, 3 months ago (2017-09-19 20:29:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698