Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 3018513002: Revert of Completed the functionalities of SrtpTransport. (Closed)

Created:
3 years, 3 months ago by Zhi Huang
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Completed the functionalities of SrtpTransport. (patchset 7 id:320001 of https://codereview.webrtc.org/2997983002/ ) Reason for revert: This seems to be causing some video freezes. See https://bugs.chromium.org/p/webrtc/issues/detail?id=8251 Original issue's description: > Completed the functionalities of SrtpTransport. > > The SrtpTransport takes the SRTP responsibilities from the BaseChannel > and SrtpFilter. SrtpTransport is now responsible for setting the crypto > keys, protecting and unprotecting the packets. SrtpTransport doesn't know > if the keys are from SDES or DTLS handshake. > > BaseChannel is now only responsible setting the offer/answer for SDES > or extracting the key from DtlsTransport and configuring the > SrtpTransport. > > SrtpFilter is used by BaseChannel as a helper for SDES negotiation. > > BUG=webrtc:7013 > > Review-Url: https://codereview.webrtc.org/2997983002 > Cr-Commit-Position: refs/heads/master@{#19636} > Committed: https://chromium.googlesource.com/external/webrtc/+/e683c6871fef24d3ff64f085d6bc0e965f17fcf7 TBR=deadbeef@webrtc.org,pthatcher@google.com,zhihuang@webrtc.org Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7013 Review-Url: https://codereview.webrtc.org/3018513002 Cr-Commit-Position: refs/heads/master@{#19895} Committed: https://webrtc.googlesource.com/src/+/eb23e1779822ef34df5f62903e19741b76cafdb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+904 lines, -1093 lines) Patch
M p2p/base/fakepackettransport.h View 2 chunks +0 lines, -4 lines 0 comments Download
M pc/channel.h View 6 chunks +12 lines, -13 lines 0 comments Download
M pc/channel.cc View 14 chunks +156 lines, -130 lines 0 comments Download
M pc/channel_unittest.cc View 7 chunks +19 lines, -19 lines 0 comments Download
M pc/rtptransport.h View 2 chunks +4 lines, -12 lines 0 comments Download
M pc/rtptransport.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M pc/rtptransportinternal.h View 1 chunk +4 lines, -7 lines 0 comments Download
M pc/srtpfilter.h View 5 chunks +77 lines, -19 lines 0 comments Download
M pc/srtpfilter.cc View 5 chunks +279 lines, -57 lines 0 comments Download
M pc/srtpfilter_unittest.cc View 16 chunks +302 lines, -31 lines 0 comments Download
M pc/srtptransport.h View 3 chunks +10 lines, -100 lines 0 comments Download
M pc/srtptransport.cc View 2 chunks +3 lines, -305 lines 0 comments Download
M pc/srtptransport_unittest.cc View 1 chunk +38 lines, -384 lines 0 comments Download

Messages

Total messages: 10 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3018513002/1
3 years, 3 months ago (2017-09-19 07:37:42 UTC) #7
commit-bot: I haz the power
3 years, 3 months ago (2017-09-19 08:12:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://webrtc.googlesource.com/src/+/eb23e1779822ef34df5f62903e19741b76cafdb9

Powered by Google App Engine
This is Rietveld 408576698