Remove BasicPortAllocator::EnableProtocol.

Remove BasicPortAllocator::EnableProtocol.

I'm not sure why we ever had this in the first place, and it confuses
people on a nearly weekly basis, so let's get rid of it. The protocols
are enabled right after the corresponding gathering is done, so the only
real effect it has is to produce confusing log messages (first
"candidate not signaled because protocol not enabled", then "protocol
enabled, signaling candidate" right afterwards).

BUG=None

Review-Url: https://codereview.webrtc.org/3018483002
Cr-Commit-Position: refs/heads/master@{#19873}
Committed: https://webrtc.googlesource.com/src/+/1c5e6d0a3f6f7ca2f20bbce354fdf4ee92b2ce93

[Taylor Brandstetter, 2017-09-14 23:09:38]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org, zhihuang@webrtc.org

[Taylor Brandstetter, 2017-09-14 23:09:39]

PTAL Peter or Zhi

[Zhi Huang, 2017-09-15 06:18:17]

lgtm

[Taylor Brandstetter, 2017-09-15 23:00:37]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-09-15 23:00:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-15 23:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-15 23:03:15]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/25093)

[Taylor Brandstetter, 2017-09-16 00:11:13]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-09-16 00:11:14]

The patchset sent to the CQ was uploaded after l-g-t-m from zhihuang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3018483002/#ps20001 (title:
"Rebase onto master")

[commit-bot: I haz the power, 2017-09-16 00:11:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-16 00:47:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505520673612510,
"parent_rev": "7f1563facf231bf6498703ce34ef3040bb380a76", "commit_rev":
"1c5e6d0a3f6f7ca2f20bbce354fdf4ee92b2ce93"}

[commit-bot: I haz the power, 2017-09-16 00:47:05]

Description was changed from

==========
Remove BasicPortAllocator::EnableProtocol.

I'm not sure why we ever had this in the first place, and it confuses
people on a nearly weekly basis, so let's get rid of it. The protocols
are enabled right after the corresponding gathering is done, so the only
real effect it has is to produce confusing log messages (first
"candidate not signaled because protocol not enabled", then "protocol
enabled, signaling candidate" right afterwards).

BUG=None
==========

to

==========
Remove BasicPortAllocator::EnableProtocol.

I'm not sure why we ever had this in the first place, and it confuses
people on a nearly weekly basis, so let's get rid of it. The protocols
are enabled right after the corresponding gathering is done, so the only
real effect it has is to produce confusing log messages (first
"candidate not signaled because protocol not enabled", then "protocol
enabled, signaling candidate" right afterwards).

BUG=None

Review-Url: https://codereview.webrtc.org/3018483002
Cr-Commit-Position: refs/heads/master@{#19873}
Committed:
https://webrtc.googlesource.com/src/+/1c5e6d0a3f6f7ca2f20bbce354fdf4ee92b2ce93
==========

[commit-bot: I haz the power, 2017-09-16 00:47:06]

Committed patchset #2 (id:20001) as
https://webrtc.googlesource.com/src/+/1c5e6d0a3f6f7ca2f20bbce354fdf4ee92b2ce93