Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 3018473002: Fix Gn untracked headers in webrtc/media (Closed)

Created:
3 years, 3 months ago by charujain1
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Gn untracked headers in webrtc/media BUG=webrtc:7645 Review-Url: https://codereview.webrtc.org/3013063002 Cr-Original-Commit-Position: refs/heads/master@{#19824} Review-Url: https://codereview.webrtc.org/3018473002 Cr-Commit-Position: refs/heads/master@{#19844} Committed: https://webrtc.googlesource.com/src/+/6674846b4adc999f69bfdb12080749d4e4ab729d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
charujain
3 years, 3 months ago (2017-09-14 15:03:37 UTC) #3
mbonadei
On 2017/09/14 15:03:37, charujain wrote: lgtm if bots are green.
3 years, 3 months ago (2017-09-14 15:06:26 UTC) #4
kjellander_webrtc
lgtm
3 years, 3 months ago (2017-09-14 16:45:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3018473002/1
3 years, 3 months ago (2017-09-14 20:35:31 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-14 20:53:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://webrtc.googlesource.com/src/+/6674846b4adc999f69bfdb12080749d4e4ab729d

Powered by Google App Engine
This is Rietveld 408576698