Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 3018433002: Update URLs for deps/third_party/* in DEPS (Closed)

Created:
3 years, 3 months ago by ehmaldonado_webrtc
Modified:
3 years, 3 months ago
CC:
niklas.enbom, peah-webrtc, qiang.lu, webrtc-reviews_webrtc.org, yujie_mao (webrtc)
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update URLs for deps/third_party/* in DEPS BUG=chromium:738330 R=agable@chromium.org TBR=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/3018433002 . Cr-Commit-Position: refs/heads/master@{#19827} Committed: https://webrtc.googlesource.com/src/+/a9d4da85ddae4b6750d92e3606e77c885add0659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M DEPS View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
ehmaldonado_webrtc
3 years, 3 months ago (2017-09-13 22:38:54 UTC) #2
agable
lgtm
3 years, 3 months ago (2017-09-13 22:45:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3018433002/1
3 years, 3 months ago (2017-09-13 22:50:33 UTC) #9
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
3 years, 3 months ago (2017-09-13 23:09:25 UTC) #11
kjellander_webrtc
Committed patchset #1 (id:1) manually as a9d4da85ddae4b6750d92e3606e77c885add0659 (presubmit successful).
3 years, 3 months ago (2017-09-14 05:28:24 UTC) #13
kjellander_webrtc
3 years, 3 months ago (2017-09-14 05:29:01 UTC) #14
Message was sent while issue was closed.
I landed this with git cl land. Unclear to me why the CQ had issues, it applies
cleanly.

Powered by Google App Engine
This is Rietveld 408576698