Roll typ to the latest version

Roll typ to the latest version

[nednguyen, 2017-09-25 12:35:24]

nednguyen@google.com changed reviewers:
+ dpranke@chromium.org

[nednguyen, 2017-09-25 12:35:29]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-09-25 12:35:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-25 12:44:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-25 12:44:46]

Dry run: Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

[dpranke, 2017-09-25 19:15:07]

dpranke@google.com changed reviewers:
+ dpranke@google.com

[dpranke, 2017-09-25 19:15:07]

lgtm

[nednguyen, 2017-09-25 19:15:53]

On 2017/09/25 19:15:07, dpranke wrote:
> lgtm

This is failing, so seems like we have some API change in typ

Traceback (most recent call last):
  <module> at
/b/build/slave/Catapult_Linux_Tryserver/build/catapult/telemetry/telemetry/testing/run_tests.py:302
    ret_code = RunTestsCommand.main()
  main at
/b/build/slave/Catapult_Linux_Tryserver/build/catapult/telemetry/telemetry/testing/run_tests.py:123
    return obj.Run(options)
  Run at
/b/build/slave/Catapult_Linux_Tryserver/build/catapult/telemetry/telemetry/testing/run_tests.py:176
    runner.args.top_level_dir = args.top_level_dir
AttributeError: BrowserFinderOptions instance has no attribute 'top_level_dir'

Locals:
  args                          : [('android_blacklist_file', None),
('browser_executable', None), ('browser_options', [('_browser_startup_timeout',
60), ('_extra_browser_args', set(['--disable-gpu'])),
('block_modal_permission_prompts', True), ('browser_type', 'reference'),
('browser_user_agent_type', None),
('clear_sytem_cache_for_browser_and_profile_on_start', False),
('disable_background_networking', True),
('disable_component_extensions_with_background_pages', True),
('disable_default_apps', True), ('dont_override_profile', False),  ...
rm_options.AndroidPlatformOptions object at 0x7f17ee3646d0>), ('repeat_count',
1), ('retry_limit', 3), ('run_disabled_tests', False), ('shard_index', 0),
('show_stdout', None), ('skip', []), ('start_xvfb', True),
('test_results_server', None), ('test_type', None), ('timing', False),
('top_level_dirs',
['/b/build/slave/Catapult_Linux_Tryserver/build/catapult/telemetry/bin/..']),
('total_shards', 1), ('verbosity', 0), ('webview_embedder_apk', None),
('write_full_results_to', None), ('write_trace_to', None)] (truncated)
  fetch_reference_chrome_binary : True
  platform                      : <telemetry.core.platform.Platform object at
0x7f17ee0fff90>
  possible_browser              : PossibleDesktopBrowser(type=reference,
executable=/b/build/slave/Catapult_Linux_Tryserver/build/catapult/common/py_utils/py_utils/bin/reference_build/chrome_stable_linux_x86_64_a142d0d947a125b5440b648125f5c1c37b401f6a/chrome-linux64/chrome,
flash=None)
  runner                        : <typ.runner.Runner object at 0x7f17ed569dd0>

**Non zero exit code**
If you don't see any error stack, this could have been a native crash. Consider
installing faulthandler (https://faulthandler.readthedocs.io/) for more useful
error message
Traceback (most recent call last):
  File
"/b/build/slave/Catapult_Linux_Tryserver/build/catapult/catapult_build/fetch_telemetry_deps_and_run_tests",
line 28, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/build/slave/Catapult_Linux_Tryserver/build/catapult/catapult_build/fetch_telemetry_deps_and_run_tests",
line 24, in main
    [sys.executable, os.path.join(_TELEMETRY_BIN_DIR, 'run_tests')] + args)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python',
'/b/build/slave/Catapult_Linux_Tryserver/build/catapult/telemetry/bin/run_tests',
'--browser=reference', '--start-xvfb']' returned non-zero exit status 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

[dpranke, 2017-09-25 19:31:01]

On 2017/09/25 19:15:53, nednguyen wrote:
> On 2017/09/25 19:15:07, dpranke wrote:
> > lgtm
> 
> This is failing, so seems like we have some API change in typ

Well, sorta. See:

https://github.com/dpranke/typ/commit/1e254b3ef4d14dee6109d8c3a58ab64d1500e3c2

But that was supposed to be a backwards-compatible change (i.e., not an API
change).

The error is complaining that `top_level_dir` is not part of
`BrowserFinderOptions`, though, 
and I don't see that listed in browser_options.py. So I don't know where that
would've 
been coming from or how the typ change might've affected it. 

top_level_dir is theoretically deprecated and replaced by top_level_dirs, which
is a list. So if 
changing to use that instead fixes the problem, you might want to do that, but
since I don't
understand what's going on, I'm not sure what the right fix is. If we need to
change something 
in typ to better preserve compatibility we can do that.

[nednguyen, 2017-09-25 21:33:24]

On 2017/09/25 19:31:01, dpranke wrote:
> On 2017/09/25 19:15:53, nednguyen wrote:
> > On 2017/09/25 19:15:07, dpranke wrote:
> > > lgtm
> > 
> > This is failing, so seems like we have some API change in typ
> 
> Well, sorta. See:
> 
> https://github.com/dpranke/typ/commit/1e254b3ef4d14dee6109d8c3a58ab64d1500e3c2
> 
> But that was supposed to be a backwards-compatible change (i.e., not an API
> change).
> 
> The error is complaining that `top_level_dir` is not part of
> `BrowserFinderOptions`, though, 
> and I don't see that listed in browser_options.py. So I don't know where that
> would've 
> been coming from or how the typ change might've affected it. 
> 
> top_level_dir is theoretically deprecated and replaced by top_level_dirs,
which
> is a list. So if 
> changing to use that instead fixes the problem, you might want to do that, but
> since I don't
> understand what's going on, I'm not sure what the right fix is. If we need to
> change something 
> in typ to better preserve compatibility we can do that.

No worries, lemme see which assumption broken & see if we should update Typ or
just Telemetry hook up code.