Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1546)

Issue 3017613002: Continuously request keyframes if decoding does not recover. (Closed)

Created:
3 years, 2 months ago by philipel
Modified:
3 years, 2 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Continuously request keyframes if decoding does not recover. This is a workaround until downstream projects have been fixed. BUG=webrtc:8220 Review-Url: https://codereview.webrtc.org/3017613002 Cr-Commit-Position: refs/heads/master@{#19966} Committed: https://webrtc.googlesource.com/src/+/48462b6ef707e9a790579090085f73e6982c3558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M video/video_receive_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M video/video_receive_stream.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
philipel
PTAL
3 years, 2 months ago (2017-09-25 12:04:56 UTC) #2
daniela-webrtc
This solves the issue. Thanks! LGTM
3 years, 2 months ago (2017-09-25 12:40:59 UTC) #5
philipel
Erik, PTAL
3 years, 2 months ago (2017-09-25 12:44:25 UTC) #7
philipel
3 years, 2 months ago (2017-09-25 12:45:19 UTC) #8
sprang_webrtc
Looks good, but where's the unit test? ;)
3 years, 2 months ago (2017-09-26 07:47:45 UTC) #9
sprang_webrtc
As discussed offline, this class is basically untestable and needs a major refactoring :( lgtm
3 years, 2 months ago (2017-09-26 09:14:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3017613002/1
3 years, 2 months ago (2017-09-26 09:21:26 UTC) #12
commit-bot: I haz the power
3 years, 2 months ago (2017-09-26 09:55:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://webrtc.googlesource.com/src/+/48462b6ef707e9a790579090085f73e6982c3558

Powered by Google App Engine
This is Rietveld 408576698