Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 3016513002: Fix Gn untracked headers in webrtc/p2p

Created:
2 months, 4 weeks ago by charujain1
Modified:
2 months, 2 weeks ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, phoglund
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Gn untracked headers in webrtc/p2p BUG=webrtc:7646 CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal Review-Url: https://codereview.webrtc.org/3013063002 Cr-Commit-Position: refs/heads/master@{#19824}

Patch Set 1 #

Patch Set 2 : rebased. #

Total comments: 2

Messages

Total messages: 11 (4 generated)
charujain
On 2017/09/14 15:31:39, charujain wrote: > mailto:charujain@webrtc.org changed reviewers: > + mailto:kjellander@google.com, mailto:mbonadei@webrtc.org PTAL.
2 months, 3 weeks ago (2017-09-19 08:57:29 UTC) #3
mbonadei
https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn File p2p/BUILD.gn (right): https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn#newcode127 p2p/BUILD.gn:127: "base/transportchannelimpl.h", I am missing some context here so maybe ...
2 months, 3 weeks ago (2017-09-19 09:04:50 UTC) #4
kjellander_webrtc
+deadbeef@ as OWNER https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn File p2p/BUILD.gn (right): https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn#newcode127 p2p/BUILD.gn:127: "base/transportchannelimpl.h", On 2017/09/19 09:04:50, mbonadei wrote: ...
2 months, 3 weeks ago (2017-09-19 16:10:29 UTC) #7
charujain
On 2017/09/19 16:10:29, kjellander_webrtc wrote: > +deadbeef@ as OWNER > > https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn > File p2p/BUILD.gn ...
2 months, 3 weeks ago (2017-09-22 11:16:32 UTC) #8
Taylor Brandstetter
On 2017/09/22 11:16:32, charujain wrote: > On 2017/09/19 16:10:29, kjellander_webrtc wrote: > > +deadbeef@ as ...
2 months, 3 weeks ago (2017-09-22 14:09:33 UTC) #9
Taylor Brandstetter
Oh, and lgtm I guess
2 months, 3 weeks ago (2017-09-22 14:10:05 UTC) #10
kjellander_webrtc
2 months, 2 weeks ago (2017-09-28 08:46:29 UTC) #11
land this now?

Powered by Google App Engine
This is Rietveld 0eb02b776