Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3015693002: Remove internal video codec methods from global namespace.

Created:
3 years, 2 months ago by kthelgason
Modified:
3 years, 2 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove internal video codec methods from global namespace. It's rude to clobber the global namespace with your symbols. BUG=None.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
kthelgason
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
3 years, 2 months ago (2017-09-25 07:04:51 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3015693002/1
3 years, 2 months ago (2017-09-25 07:04:59 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 2 months ago (2017-09-25 07:09:48 UTC) #3
commit-bot: I haz the power
3 years, 2 months ago (2017-09-25 07:09:48 UTC) #4 
Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21935)

Powered by Google App Engine
This is Rietveld 408576698