Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3015683002:
Modify some rate control and quality thresholds due to flakiness. (Closed)
|
Created:
3 years, 3 months ago by åsapersson Modified:
3 years, 2 months ago Reviewers:
brandtr CC:
webrtc-reviews_webrtc.org Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionModify some rate control and quality thresholds due to flakiness.
BUG=webrtc:8280
Review-Url: https://codereview.webrtc.org/3015683002
Cr-Commit-Position: refs/heads/master@{#19968}
Committed: https://webrtc.googlesource.com/src/+/e19d8bfd5b680715f10e82bd464d74f06556b5dc
Patch Set 1 #Patch Set 2 : modify ssim avg #Patch Set 3 : update bitrate mismatch percent #Patch Set 4 #
Total comments: 1
Patch Set 5 : rebase and reenable test #Messages
Total messages: 22 (18 generated)
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Increase rate control threshold for maximum number of dropped frames due to flakiness. BUG=none ========== to ========== Increase rate control threshold for maximum number of dropped frames due to flakiness. BUG=none ==========
asapersson@webrtc.org changed reviewers: + brandtr@webrtc.org
Patchset #6 (id:100001) has been deleted
Patchset #4 (id:60001) has been deleted
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Increase rate control threshold for maximum number of dropped frames due to flakiness. BUG=none ========== to ========== Modify rate control and quality thresholds due to flakiness. BUG=none ==========
Description was changed from ========== Modify rate control and quality thresholds due to flakiness. BUG=none ========== to ========== Modify some rate control and quality thresholds due to flakiness. BUG=none ==========
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks for fixing this! Add 8280 as the bug. lgtm https://codereview.webrtc.org/3015683002/diff/120001/modules/video_coding/cod... File modules/video_coding/codecs/test/videoprocessor_integrationtest_mediacodec.cc (right): https://codereview.webrtc.org/3015683002/diff/120001/modules/video_coding/cod... modules/video_coding/codecs/test/videoprocessor_integrationtest_mediacodec.cc:42: TEST_F(VideoProcessorIntegrationTestMediaCodec, ForemanCif500kbpsVp8) { This test has since been disabled, so you need to rebase and update the name here :)
Description was changed from ========== Modify some rate control and quality thresholds due to flakiness. BUG=none ========== to ========== Modify some rate control and quality thresholds due to flakiness. BUG=webrtc:8280 ==========
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org Link to the patchset: https://codereview.webrtc.org/3015683002/#ps140001 (title: "rebase and reenable test")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1506419567574320,
"parent_rev": "c00240c2282282c5557c5b426f1e6705f0808919", "commit_rev":
"e19d8bfd5b680715f10e82bd464d74f06556b5dc"}
Message was sent while issue was closed.
Description was changed from ========== Modify some rate control and quality thresholds due to flakiness. BUG=webrtc:8280 ========== to ========== Modify some rate control and quality thresholds due to flakiness. BUG=webrtc:8280 Review-Url: https://codereview.webrtc.org/3015683002 Cr-Commit-Position: refs/heads/master@{#19968} Committed: https://webrtc.googlesource.com/src/+/e19d8bfd5b680715f10e82bd464d74f06556b5dc ==========
Message was sent while issue was closed.
Committed patchset #5 (id:140001) as https://webrtc.googlesource.com/src/+/e19d8bfd5b680715f10e82bd464d74f06556b5dc |
