Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 3015663002: [Experiment] Alpha Channel Support

Created:
3 years, 3 months ago by qiangchen
Modified:
3 years, 3 months ago
Reviewers:
emircan, GeorgeZ
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Alpha Channel Support Essentially rebased from https://codereview.chromium.org/2951033003/ Add webrtc_unity_plugin change for alpha channel support. BUG=

Patch Set 1 #

Patch Set 2 : Remove Frame Matching On Sender Side #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1401 lines, -76 lines) Patch
M api/video/video_frame_buffer.h View 1 chunk +5 lines, -1 line 0 comments Download
M api/video/video_frame_buffer.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M api/video_codecs/video_decoder.h View 1 chunk +7 lines, -0 lines 0 comments Download
M api/video_codecs/video_encoder.h View 1 chunk +8 lines, -0 lines 0 comments Download
M call/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M call/video_send_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M common_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M common_types.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M common_video/include/video_frame_buffer.h View 1 chunk +29 lines, -0 lines 0 comments Download
M common_video/video_frame.cc View 1 chunk +1 line, -0 lines 0 comments Download
M common_video/video_frame_buffer.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M examples/unityplugin/simple_peer_connection.cc View 4 chunks +45 lines, -23 lines 0 comments Download
M examples/unityplugin/unity_plugin_apis.h View 1 chunk +6 lines, -0 lines 0 comments Download
M examples/unityplugin/video_observer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M media/base/codec.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/codec.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M media/base/mediaconstants.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/mediaconstants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/engine/webrtcvideoengine.h View 9 chunks +14 lines, -11 lines 0 comments Download
M media/engine/webrtcvideoengine.cc View 23 chunks +241 lines, -14 lines 0 comments Download
M modules/include/module_common_types.h View 2 chunks +16 lines, -6 lines 0 comments Download
M modules/rtp_rtcp/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M modules/rtp_rtcp/source/rtp_format.h View 1 chunk +1 line, -0 lines 0 comments Download
M modules/rtp_rtcp/source/rtp_format.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A modules/rtp_rtcp/source/rtp_format_video_stereo.h View 1 chunk +73 lines, -0 lines 0 comments Download
A modules/rtp_rtcp/source/rtp_format_video_stereo.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M modules/rtp_rtcp/source/rtp_payload_registry.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M modules/rtp_rtcp/source/rtp_receiver_video.cc View 1 chunk +1 line, -1 line 0 comments Download
M modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/rtp_rtcp/source/rtp_sender_video.cc View 2 chunks +4 lines, -1 line 0 comments Download
M modules/video_coding/BUILD.gn View 4 chunks +26 lines, -0 lines 0 comments Download
M modules/video_coding/codec_database.cc View 1 chunk +1 line, -0 lines 0 comments Download
A modules/video_coding/codecs/stereo/include/stereo_decoder_adapter.h View 1 chunk +70 lines, -0 lines 0 comments Download
A modules/video_coding/codecs/stereo/include/stereo_encoder_adapter.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
A modules/video_coding/codecs/stereo/stereo_adapter_unittest.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A modules/video_coding/codecs/stereo/stereo_decoder_adapter.cc View 1 chunk +201 lines, -0 lines 0 comments Download
A modules/video_coding/codecs/stereo/stereo_encoder_adapter.cc View 1 1 chunk +201 lines, -0 lines 0 comments Download
M modules/video_coding/encoded_frame.cc View 2 chunks +17 lines, -1 line 0 comments Download
M modules/video_coding/frame_buffer2.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M modules/video_coding/include/video_codec_initializer.h View 1 chunk +1 line, -0 lines 0 comments Download
M modules/video_coding/include/video_codec_interface.h View 2 chunks +8 lines, -0 lines 0 comments Download
M modules/video_coding/packet.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M modules/video_coding/rtp_frame_reference_finder.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M modules/video_coding/video_codec_initializer.cc View 4 chunks +14 lines, -3 lines 0 comments Download
M test/video_codec_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M video/payload_router.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
qiangchen
Description was changed from ========== Alpha Channel Support BUG= ========== to ========== Alpha Channel Support ...
3 years, 3 months ago (2017-09-20 17:39:13 UTC) #1
qiangchen
qiangchen@chromium.org changed reviewers: + emircan@chromium.org, gyzhou@chromium.org
3 years, 3 months ago (2017-09-21 19:43:24 UTC) #2
qiangchen
3 years, 3 months ago (2017-09-21 19:44:29 UTC) #3
Description was changed from

==========
Alpha Channel Support


BUG=
==========

to

==========
Alpha Channel Support

Essentially rebased from https://codereview.chromium.org/2951033003/
Add webrtc_unity_plugin change for alpha channel support.

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698