Reject the descriptions that attempt to change the order of m= section in current local description.

Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared
against existing m= sections and an error would be returned if the order 
doesn't match.

This change is expected to be merged to M62.

BUG=chromium:763842

[Zhi Huang, 2017-09-13 23:51:34]

Patchset #1 (id:1) has been deleted

[Zhi Huang, 2017-09-13 23:53:41]

Patchset #1 (id:20001) has been deleted

[Zhi Huang, 2017-09-13 23:53:46]

The CQ bit was checked by zhihuang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-13 23:53:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-13 23:53:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-13 23:53:53]

Dry run: CLs for remote refs other than refs/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[Zhi Huang, 2017-09-14 00:08:54]

Description was changed from

==========
Reject the re-offers that attempt to change the order m= section in current
local description.
==========

to

==========
Reject the descriptions that attempt to change the order of m= sections in
current local description.

When setting the descriptions, the order of m= sections would be compared 
against existing m= sections. An error would be returned if the order 
doesn't match.

This change is expected to be merge to M62.

BUG=chromium:763842
==========

[Zhi Huang, 2017-09-14 00:09:07]

Description was changed from

==========
Reject the descriptions that attempt to change the order of m= sections in
current local description.

When setting the descriptions, the order of m= sections would be compared 
against existing m= sections. An error would be returned if the order 
doesn't match.

This change is expected to be merge to M62.

BUG=chromium:763842
==========

to

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared 
against existing m= sections. An error would be returned if the order 
doesn't match.

This change is expected to be merge to M62.

BUG=chromium:763842
==========

[Zhi Huang, 2017-09-14 00:09:43]

Description was changed from

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared 
against existing m= sections. An error would be returned if the order 
doesn't match.

This change is expected to be merge to M62.

BUG=chromium:763842
==========

to

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared
against existing m= sections and An error would be returned if 
the order doesn't match.

This change is expected to be merge to M62.

BUG=chromium:763842
==========

[Zhi Huang, 2017-09-14 00:10:02]

Description was changed from

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared
against existing m= sections and An error would be returned if 
the order doesn't match.

This change is expected to be merge to M62.

BUG=chromium:763842
==========

to

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared
 against existing m= sections and An error would be returned if 
the order doesn't match.

This change is expected to be merge to M62.

BUG=chromium:763842
==========

[Zhi Huang, 2017-09-14 00:10:18]

Description was changed from

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared
 against existing m= sections and An error would be returned if 
the order doesn't match.

This change is expected to be merge to M62.

BUG=chromium:763842
==========

to

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared
against existing m= sections and An error would be returned if the order 
doesn't match.

This change is expected to be merge to M62.

BUG=chromium:763842
==========

[Zhi Huang, 2017-09-14 00:10:23]

Description was changed from

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared
against existing m= sections and An error would be returned if the order 
doesn't match.

This change is expected to be merge to M62.

BUG=chromium:763842
==========

to

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared
against existing m= sections and An error would be returned if the order 
doesn't match.

This change is expected to be merged to M62.

BUG=chromium:763842
==========

[Zhi Huang, 2017-09-14 00:10:47]

Description was changed from

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared
against existing m= sections and An error would be returned if the order 
doesn't match.

This change is expected to be merged to M62.

BUG=chromium:763842
==========

to

==========
Reject the descriptions that attempt to change the order of m= sections
in current local description.

When setting the descriptions, the order of m= sections would be compared
against existing m= sections and an error would be returned if the order 
doesn't match.

This change is expected to be merged to M62.

BUG=chromium:763842
==========

[Zhi Huang, 2017-09-14 00:14:24]

zhihuang@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Zhi Huang, 2017-09-14 00:14:24]

PTAL.

[Zhi Huang, 2017-09-14 00:14:55]

zhihuang@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2017-09-14 00:41:47]

lgtm with nits

https://codereview.webrtc.org/3015473002/diff/40001/webrtc/pc/peerconnectioni...
File webrtc/pc/peerconnectioninterface_unittest.cc (right):

https://codereview.webrtc.org/3015473002/diff/40001/webrtc/pc/peerconnectioni...
webrtc/pc/peerconnectioninterface_unittest.cc:1244: void
ReorderMediaSections(SessionDescriptionInterface* session_description) {
nit: This could be simplified by using std::reverse. It then would be such a
small amount of code it could go in the test itself:

std::reverse(offer->description()->contents().begin(),
             offer->description()->contents().end());
std::reverse(offer->description()->transport_infos().begin(),
             offer->description()->transport_infos().end());

https://codereview.webrtc.org/3015473002/diff/40001/webrtc/pc/peerconnectioni...
webrtc/pc/peerconnectioninterface_unittest.cc:3866: // An remote offer with
different m=line order would be rejected.
nit: "A" instead of "An", and "should" instead of "would"

https://codereview.webrtc.org/3015473002/diff/40001/webrtc/pc/webrtcsession.h
File webrtc/pc/webrtcsession.h (right):

https://codereview.webrtc.org/3015473002/diff/40001/webrtc/pc/webrtcsession.h...
webrtc/pc/webrtcsession.h:65: extern const char kMlineMismatchInSubOffer[];
nit: Might as well just spell out "Subsequent"