Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3015433002: Allow passing null for RTCcodecSpecific info in encoder callback.

Created:
3 years, 3 months ago by kthelgason
Modified:
3 years, 2 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow passing null for RTCcodecSpecific info in encoder callback. BUG=None

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
kthelgason
Make sure to be sitting down for this one!
3 years, 3 months ago (2017-09-13 07:24:30 UTC) #8
magjed_webrtc
lgtm :)
3 years, 3 months ago (2017-09-14 10:25:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3015433002/20001
3 years, 2 months ago (2017-09-28 13:48:04 UTC) #13
commit-bot: I haz the power
3 years, 2 months ago (2017-09-28 13:52:34 UTC) #15 
Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/25373)

Powered by Google App Engine
This is Rietveld 408576698