Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: dashboard/dashboard/pinpoint/elements/execution-status.html

Issue 3014663002: [pinpoint] Add trace links.
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/elements/execution-status.html
diff --git a/dashboard/dashboard/pinpoint/elements/execution-status.html b/dashboard/dashboard/pinpoint/elements/execution-status.html
index 24779b7c55466237d672b81e788a3043090e4d7d..661f512d5cca1e11e5c46506c1dec9aacda89fd3 100644
--- a/dashboard/dashboard/pinpoint/elements/execution-status.html
+++ b/dashboard/dashboard/pinpoint/elements/execution-status.html
@@ -161,6 +161,8 @@ found in the LICENSE file.
continue;
}
+ // TODO: Generate the correct URLs in the backend to avoid these
+ // hard-coded keys and base URLs.
let url = '';
if (key == 'bot_id') {
url = 'https://chromium-swarm.appspot.com/bot?id=' + value;
@@ -170,6 +172,8 @@ found in the LICENSE file.
url = 'https://isolateserver.appspot.com/browse?digest=' + value;
} else if (key == 'task_id') {
url = 'https://chromium-swarm.appspot.com/task?id=' + value;
+ } else if (key == 'trace_url') {
+ url = value;
}
executionDetails.push({key, value, url});

Powered by Google App Engine
This is Rietveld 408576698