Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: dashboard/dashboard/pinpoint/elements/execution-status.html

Issue 3014663002: [pinpoint] Add trace links.
Patch Set: Created 3 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 Copyright 2017 The Chromium Authors. All rights reserved. 3 Copyright 2017 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <link rel="import" href="/components/iron-selector/iron-selector.html"> 8 <link rel="import" href="/components/iron-selector/iron-selector.html">
9 9
10 <link rel="import" href="/dashboard/pinpoint/elements/base-style.html"> 10 <link rel="import" href="/dashboard/pinpoint/elements/base-style.html">
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 const details = 154 const details =
155 Object.assign(execution.details, execution.result_arguments); 155 Object.assign(execution.details, execution.result_arguments);
156 156
157 const executionDetails = []; 157 const executionDetails = [];
158 for (const key in details) { 158 for (const key in details) {
159 const value = details[key]; 159 const value = details[key];
160 if (!value) { 160 if (!value) {
161 continue; 161 continue;
162 } 162 }
163 163
164 // TODO: Generate the correct URLs in the backend to avoid these
165 // hard-coded keys and base URLs.
164 let url = ''; 166 let url = '';
165 if (key == 'bot_id') { 167 if (key == 'bot_id') {
166 url = 'https://chromium-swarm.appspot.com/bot?id=' + value; 168 url = 'https://chromium-swarm.appspot.com/bot?id=' + value;
167 } else if (key == 'build') { 169 } else if (key == 'build') {
168 // TODO: Buildbucket doesn't have a UI. Provide some kind of link. 170 // TODO: Buildbucket doesn't have a UI. Provide some kind of link.
169 } else if (key == 'isolate_hash') { 171 } else if (key == 'isolate_hash') {
170 url = 'https://isolateserver.appspot.com/browse?digest=' + value; 172 url = 'https://isolateserver.appspot.com/browse?digest=' + value;
171 } else if (key == 'task_id') { 173 } else if (key == 'task_id') {
172 url = 'https://chromium-swarm.appspot.com/task?id=' + value; 174 url = 'https://chromium-swarm.appspot.com/task?id=' + value;
175 } else if (key == 'trace_url') {
176 url = value;
173 } 177 }
174 178
175 executionDetails.push({key, value, url}); 179 executionDetails.push({key, value, url});
176 } 180 }
177 return executionDetails; 181 return executionDetails;
178 }, 182 },
179 }); 183 });
180 </script> 184 </script>
181 </dom-module> 185 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698