Chromium Code Reviews| Index: modules/video_coding/codecs/test/videoprocessor_integrationtest.h |
| diff --git a/modules/video_coding/codecs/test/videoprocessor_integrationtest.h b/modules/video_coding/codecs/test/videoprocessor_integrationtest.h |
| index 2ab65025a0a6c0f41e1f64e666d1ca543242fabc..9f0af53176e1122953e6f5e87dac1bf323dc04e1 100644 |
| --- a/modules/video_coding/codecs/test/videoprocessor_integrationtest.h |
| +++ b/modules/video_coding/codecs/test/videoprocessor_integrationtest.h |
| @@ -71,6 +71,12 @@ struct QualityThresholds { |
| double min_min_ssim; |
| }; |
| +struct BitstreamThresholds { |
| + explicit BitstreamThresholds(size_t max_nalu_length) |
|
brandtr
2017/09/26 09:19:13
Not sure if the ctor serves a purpose together wit
ssilkin
2017/09/26 11:07:05
Agree. No need in rtc::Otional here. Changed to si
|
| + : max_nalu_length(max_nalu_length) {} |
| + rtc::Optional<size_t> max_nalu_length; |
| +}; |
| + |
| // Should video files be saved persistently to disk for post-run visualization? |
| struct VisualizationParams { |
| bool save_encoded_ivf; |
| @@ -122,6 +128,7 @@ class VideoProcessorIntegrationTest : public testing::Test { |
| const RateProfile& rate_profile, |
| const std::vector<RateControlThresholds>* rc_thresholds, |
| const QualityThresholds* quality_thresholds, |
| + const BitstreamThresholds* bs_thresholds, |
| const VisualizationParams* visualization_params); |
| // Config. |
| @@ -192,6 +199,9 @@ class VideoProcessorIntegrationTest : public testing::Test { |
| const std::vector<int>& num_dropped_frames, |
| const std::vector<int>& num_spatial_resizes) const; |
| + void VerifyBitstream(int frame_number, |
|
hbos
2017/09/25 16:13:41
Does it make more sense for frame_number to be siz
ssilkin
2017/09/26 09:17:52
Agree. There are tons of ints in videoprocessor wh
brandtr
2017/09/26 09:19:13
You are right, but the frame numbers are ints in t
|
| + const BitstreamThresholds *bs_thresholds); |
|
hbos
2017/09/25 16:13:41
nit: const BitstreamThresholds* bs_thresholds (* i
ssilkin
2017/09/26 09:17:52
Done.
|
| + |
| // Codecs. |
| std::unique_ptr<VideoEncoder> encoder_; |
| std::unique_ptr<cricket::WebRtcVideoDecoderFactory> decoder_factory_; |