Adding test for SingleNalUnit mode

modules/video_coding/codecs/test/videoprocessor_integrationtest.h

 /*
  *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 53 matching lines @@
       : min_avg_psnr(min_avg_psnr),
         min_min_psnr(min_min_psnr),
         min_avg_ssim(min_avg_ssim),
         min_min_ssim(min_min_ssim) {}
   double min_avg_psnr;
   double min_min_psnr;
   double min_avg_ssim;
   double min_min_ssim;
 };
 
+struct BitstreamThresholds {
+  explicit BitstreamThresholds(size_t max_nalu_length)

[brandtr, 2017/09/26 09:19:13]

Not sure if the ctor serves a purpose together with the rtc::Optional? If an
object of this type is instantiated, it must necessarily have |max_nalu_length|
set?

[ssilkin, 2017/09/26 11:07:05]

Agree. No need in rtc::Otional here. Changed to size_t.

+    : max_nalu_length(max_nalu_length) {}
+    rtc::Optional<size_t> max_nalu_length;
+};
+
 // Should video files be saved persistently to disk for post-run visualization?
 struct VisualizationParams {
   bool save_encoded_ivf;
   bool save_decoded_y4m;
 };
 
 // Integration test for video processor. Encodes+decodes a clip and
 // writes it to the output directory. After completion, quality metrics
 // (PSNR and SSIM) and rate control metrics are computed and compared to given
 // thresholds, to verify that the quality and encoder response is acceptable.
@@ skipping 31 matching lines @@
       int max_bitrate_mismatch_percent,
       int max_num_frames_to_hit_target,
       int num_spatial_resizes,
       int num_key_frames,
       std::vector<RateControlThresholds>* rc_thresholds);
 
   void ProcessFramesAndMaybeVerify(
       const RateProfile& rate_profile,
       const std::vector<RateControlThresholds>* rc_thresholds,
       const QualityThresholds* quality_thresholds,
+      const BitstreamThresholds* bs_thresholds,
       const VisualizationParams* visualization_params);
 
   // Config.
   TestConfig config_;
 
  private:
   static const int kMaxNumTemporalLayers = 3;
 
   struct TestResults {
     int KeyFrameSizeMismatchPercent() const {
@@ skipping 50 matching lines @@
   void PrintRateControlMetrics(
       int rate_update_index,
       const std::vector<int>& num_dropped_frames,
       const std::vector<int>& num_spatial_resizes) const;
   void VerifyRateControlMetrics(
       int rate_update_index,
       const std::vector<RateControlThresholds>* rc_thresholds,
       const std::vector<int>& num_dropped_frames,
       const std::vector<int>& num_spatial_resizes) const;
 
+  void VerifyBitstream(int frame_number,

[hbos, 2017/09/25 16:13:41]

Does it make more sense for frame_number to be size_t? It's used as an index and
should never be negative, right?

[ssilkin, 2017/09/26 09:17:52]

Agree. There are tons of ints in videoprocessor which only take positive values
and should be size_t. However, I would suggest to keep it as it as for now  and
do refactoring separately. It is just too big change for this little CL.

[brandtr, 2017/09/26 09:19:13]

You are right, but the frame numbers are ints in the rest of the test. Could be
a followup to fix though.

+      const BitstreamThresholds *bs_thresholds);

[hbos, 2017/09/25 16:13:41]

nit: const BitstreamThresholds* bs_thresholds (* is part of the type).

And the indentation is wrong, it should be:
void VerifyBitstream(int frame_number,
                     const BitstreamThresholds* bs_thresholds);
See git cl format .

[ssilkin, 2017/09/26 09:17:52]

Done.

+
   // Codecs.
   std::unique_ptr<VideoEncoder> encoder_;
   std::unique_ptr<cricket::WebRtcVideoDecoderFactory> decoder_factory_;
   VideoDecoder* decoder_;
 
   // Helper objects.
   std::unique_ptr<FrameReader> analysis_frame_reader_;
   std::unique_ptr<FrameWriter> analysis_frame_writer_;
   std::unique_ptr<IvfFileWriter> encoded_frame_writer_;
   std::unique_ptr<FrameWriter> decoded_frame_writer_;
   PacketReader packet_reader_;
   std::unique_ptr<PacketManipulator> packet_manipulator_;
   Stats stats_;
   std::unique_ptr<VideoProcessor> processor_;
 
   // Quantities updated for every encoded frame.
   TestResults actual_;
 
   // Rates set for every encoder rate update.
   TargetRates target_;
 };
 
 }  // namespace test
 }  // namespace webrtc
 
 #endif  // MODULES_VIDEO_CODING_CODECS_TEST_VIDEOPROCESSOR_INTEGRATIONTEST_H_