[pinpoint] Add message in bug when there are no change points.

[pinpoint] Add message in bug when there are no change points.

Review-Url: https://chromiumcodereview.appspot.com/3014583002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7c2bbd63e944d95c1753decde3b16921de34e060

[dtu, 2017-09-18 20:54:22]

dtu@chromium.org changed reviewers:
+ perezju@chromium.org, simonhatch@chromium.org, sullivan@chromium.org

[sullivan, 2017-09-18 20:55:48]

https://codereview.chromium.org/3014583002/diff/1/dashboard/dashboard/pinpoin...
File dashboard/dashboard/pinpoint/models/job.py (right):

https://codereview.chromium.org/3014583002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/job.py:177: change_details.append('No change
points found.')
This might be a little confusing to users. "No significant performance change
found in range?"

[shatch, 2017-09-18 21:00:15]

https://codereview.chromium.org/3014583002/diff/1/dashboard/dashboard/pinpoin...
File dashboard/dashboard/pinpoint/models/job.py (right):

https://codereview.chromium.org/3014583002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/job.py:177: change_details.append('No change
points found.')
Kinda wonder if people will ask what this means, might be cleared if it said
something more along the lines of 'Couldn't reproduce a difference' or
something. We could just land this and see though.

[perezju, 2017-09-19 11:56:07]

https://codereview.chromium.org/3014583002/diff/1/dashboard/dashboard/pinpoin...
File dashboard/dashboard/pinpoint/models/job.py (right):

https://codereview.chromium.org/3014583002/diff/1/dashboard/dashboard/pinpoin...
dashboard/dashboard/pinpoint/models/job.py:177: change_details.append('No change
points found.')
On 2017/09/18 21:00:14, shatch wrote:
> Kinda wonder if people will ask what this means, might be cleared if it said
> something more along the lines of 'Couldn't reproduce a difference' or
> something. We could just land this and see though.

It would also help figure out the right wording if, for the case when there
_are_ changes, we provided some sort of title; i.e. what are these CLs? Why are
you telling me about them? Maybe:

'Significant performance changes found after these CLs/this CL:'

???

[dtu, 2017-09-21 01:15:48]

What if it's a functional bisect?

[dtu, 2017-09-21 01:16:13]

On 2017/09/21 01:15:48, dtu wrote:
> What if it's a functional bisect?

Or a perf tryjob?

[perezju, 2017-09-21 09:57:18]

lgtm w/bikeshedding nits.

https://codereview.chromium.org/3014583002/diff/40001/dashboard/dashboard/pin...
File dashboard/dashboard/pinpoint/elements/job-page-header.html (right):

https://codereview.chromium.org/3014583002/diff/40001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/elements/job-page-header.html:41:
<h2>Differences</h2>
maybe: Differences found after commits

(shying away from saying "Commits causing differences")

https://codereview.chromium.org/3014583002/diff/40001/dashboard/dashboard/pin...
File dashboard/dashboard/pinpoint/models/job.py (right):

https://codereview.chromium.org/3014583002/diff/40001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/job.py:174: change_details.append(
nit: only append this when there are differences

https://codereview.chromium.org/3014583002/diff/40001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/job.py:175: '<b>Found significant
differences from %d commits:</b>' %
suggestion nits:

with multiple commits: 'Found significant differences after each of %d commits:'

with a single commit: 'Found significant differences after 1 commit:'

[dtu, 2017-09-21 19:31:31]

Patchset #4 (id:60001) has been deleted

[dtu, 2017-09-21 19:32:29]

https://codereview.chromium.org/3014583002/diff/40001/dashboard/dashboard/pin...
File dashboard/dashboard/pinpoint/elements/job-page-header.html (right):

https://codereview.chromium.org/3014583002/diff/40001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/elements/job-page-header.html:41:
<h2>Differences</h2>
On 2017/09/21 09:57:18, perezju wrote:
> maybe: Differences found after commits
> 
> (shying away from saying "Commits causing differences")

Done.

https://codereview.chromium.org/3014583002/diff/40001/dashboard/dashboard/pin...
File dashboard/dashboard/pinpoint/models/job.py (right):

https://codereview.chromium.org/3014583002/diff/40001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/job.py:174: change_details.append(
On 2017/09/21 09:57:18, perezju wrote:
> nit: only append this when there are differences

Done.

https://codereview.chromium.org/3014583002/diff/40001/dashboard/dashboard/pin...
dashboard/dashboard/pinpoint/models/job.py:175: '<b>Found significant
differences from %d commits:</b>' %
On 2017/09/21 09:57:18, perezju wrote:
> suggestion nits:
> 
> with multiple commits: 'Found significant differences after each of %d
commits:'
> 
> with a single commit: 'Found significant differences after 1 commit:'

Done.

[dtu, 2017-09-21 19:32:33]

The CQ bit was checked by dtu@chromium.org

[dtu, 2017-09-21 19:32:34]

The patchset sent to the CQ was uploaded after l-g-t-m from perezju@chromium.org
Link to the patchset: https://codereview.chromium.org/3014583002/#ps80001
(title: "Wording")

[commit-bot: I haz the power, 2017-09-21 19:32:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-21 20:04:33]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1506022353874580,
"parent_rev": "92c797fc06b6ec58704c09468f6cb6ea68003246", "commit_rev":
"7c2bbd63e944d95c1753decde3b16921de34e060"}

[commit-bot: I haz the power, 2017-09-21 20:04:37]

Description was changed from

==========
[pinpoint] Add message in bug when there are no change points.
==========

to

==========
[pinpoint] Add message in bug when there are no change points.

Review-Url: https://chromiumcodereview.appspot.com/3014583002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-21 20:04:38]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...