Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 3014473002: Add assignment operator to AudioEncoderRuntimeConfig (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
Reviewers:
terelius, danilchap
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add assignment operator to AudioEncoderRuntimeConfig Since the copy-constructor is explicitly defined, the coding-style guide mandates explicitly defining the assignment operator, too. BUG=None TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/3014473002 Cr-Commit-Position: refs/heads/master@{#19800} Committed: https://chromium.googlesource.com/external/webrtc/+/3fe3e3b8fdc4539d4c17142dda74536244b52d3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_config.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/include/audio_network_adaptor_config.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
eladalon
PTAL
3 years, 3 months ago (2017-09-12 15:05:20 UTC) #2
danilchap
lgtm
3 years, 3 months ago (2017-09-12 15:23:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3014473002/1
3 years, 3 months ago (2017-09-12 15:27:14 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-12 16:00:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/3fe3e3b8fdc4539d4c17142dd...

Powered by Google App Engine
This is Rietveld 408576698