Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 3013673002: Fix Gn Untracked headers in webrtc/common_audio (Closed)

Created:
3 years, 3 months ago by charujain1
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, kwiberg-webrtc, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1, phoglund
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Gn Untracked headers in webrtc/common_audio Fixed following headers in this CL =================================== src/webrtc/common_audio/vad/mock/mock_vad.h src/webrtc/common_audio/mocks/mock_smoothing_filter.h src/webrtc/common_audio/signal_processing/include/spl_inl_armv7.h BUG=webrtc:7648 Review-Url: https://codereview.webrtc.org/3013063002 Cr-Original-Commit-Position: refs/heads/master@{#19824} Review-Url: https://codereview.webrtc.org/3013673002 Cr-Commit-Position: refs/heads/master@{#19852} Committed: https://webrtc.googlesource.com/src/+/9a45116b5e2328a2d20c72f24a761cec170b72e3

Patch Set 1 #

Patch Set 2 : removing whitespace #

Patch Set 3 : Added missing dependency #

Patch Set 4 : made target testonly #

Total comments: 1

Patch Set 5 : rebased and review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M common_audio/BUILD.gn View 1 2 3 4 2 chunks +13 lines, -0 lines 0 comments Download
M modules/audio_coding/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
charujain
3 years, 3 months ago (2017-09-14 15:04:11 UTC) #3
mbonadei
On 2017/09/14 15:04:11, charujain wrote: lgtm
3 years, 3 months ago (2017-09-14 15:07:11 UTC) #4
kjellander_webrtc
https://codereview.webrtc.org/3013673002/diff/60001/webrtc/common_audio/BUILD.gn File webrtc/common_audio/BUILD.gn (right): https://codereview.webrtc.org/3013673002/diff/60001/webrtc/common_audio/BUILD.gn#newcode107 webrtc/common_audio/BUILD.gn:107: rtc_source_set("audio_mock_headers_utility") { other targets in the tree have the ...
3 years, 3 months ago (2017-09-14 16:44:56 UTC) #6
kjellander_webrtc
3 years, 3 months ago (2017-09-14 16:44:56 UTC) #8
charujain
On 2017/09/14 16:44:56, kjellander_webrtc wrote: > https://codereview.webrtc.org/3013673002/diff/60001/webrtc/common_audio/BUILD.gn > File webrtc/common_audio/BUILD.gn (right): > > https://codereview.webrtc.org/3013673002/diff/60001/webrtc/common_audio/BUILD.gn#newcode107 > ...
3 years, 3 months ago (2017-09-15 09:02:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013673002/80001
3 years, 3 months ago (2017-09-15 09:44:32 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-09-15 10:51:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://webrtc.googlesource.com/src/+/9a45116b5e2328a2d20c72f24a761cec170b72e3

Powered by Google App Engine
This is Rietveld 408576698