Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

Change types in interface to plain int.
When putting values into raw buffer / structures with small types, use rtc::dchecked_cast.

BUG=webrtc:1348
Review-Url: https://codereview.webrtc.org/3013623002
Cr-Commit-Position: refs/heads/master@{#19813}
Committed: https://chromium.googlesource.com/external/webrtc/+/772bd8b6a7d232c94b1d2b1d37ec7e1f9515c7a7

[danilchap, 2017-09-12 17:18:56]

Description was changed from

==========
Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

BUG=webrtc:1234
==========

to

==========
Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

BUG=webrtc:1348
==========

[danilchap, 2017-09-12 17:33:01]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-12 17:33:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-12 18:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-12 18:03:24]

Dry run: This issue passed the CQ dry run.

[danilchap, 2017-09-12 18:11:13]

Description was changed from

==========
Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

BUG=webrtc:1348
==========

to

==========
Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

Change types in the interface to plain int.
When putting values into buffer, use rtc::dchecked_cast in addition to already
existent stricter range checks.

BUG=webrtc:1348
==========

[danilchap, 2017-09-12 18:11:37]

Description was changed from

==========
Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

Change types in the interface to plain int.
When putting values into buffer, use rtc::dchecked_cast in addition to already
existent stricter range checks.

BUG=webrtc:1348
==========

to

==========
Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

Change types in interface to plain int.
When putting values into raw buffer, use rtc::dchecked_cast in addition to
already existent stricter range checks.

BUG=webrtc:1348
==========

[danilchap, 2017-09-12 18:12:17]

Description was changed from

==========
Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

Change types in interface to plain int.
When putting values into raw buffer, use rtc::dchecked_cast in addition to
already existent stricter range checks.

BUG=webrtc:1348
==========

to

==========
Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

Change types in interface to plain int.
When putting values into raw buffer / structures with small types, use
rtc::dchecked_cast.

BUG=webrtc:1348
==========

[danilchap, 2017-09-12 18:13:35]

danilchap@webrtc.org changed reviewers:
+ eladalon@webrtc.org

[danilchap, 2017-09-12 18:13:35]

Prefer to fix warnings instead of spreading them.

[eladalon, 2017-09-13 09:12:24]

lgtm

[danilchap, 2017-09-13 10:21:39]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2017-09-13 10:21:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-13 10:24:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505298099943050,
"parent_rev": "87443ee3e69abf8dbf656952d29501daa248ff2c", "commit_rev":
"772bd8b6a7d232c94b1d2b1d37ec7e1f9515c7a7"}

[commit-bot: I haz the power, 2017-09-13 10:24:33]

Description was changed from

==========
Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

Change types in interface to plain int.
When putting values into raw buffer / structures with small types, use
rtc::dchecked_cast.

BUG=webrtc:1348
==========

to

==========
Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target

Change types in interface to plain int.
When putting values into raw buffer / structures with small types, use
rtc::dchecked_cast.

BUG=webrtc:1348

Review-Url: https://codereview.webrtc.org/3013623002
Cr-Commit-Position: refs/heads/master@{#19813}
Committed:
https://chromium.googlesource.com/external/webrtc/+/772bd8b6a7d232c94b1d2b1d3...
==========

[commit-bot: I haz the power, 2017-09-13 10:24:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/772bd8b6a7d232c94b1d2b1d3...