Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 3013623002: Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target (Closed)

Created:
3 years, 3 months ago by danilchap
Modified:
3 years, 3 months ago
Reviewers:
eladalon
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix no_size_t_to_int_warning in rtp_rtcp:rtp_rtcp_format target Change types in interface to plain int. When putting values into raw buffer / structures with small types, use rtc::dchecked_cast. BUG=webrtc:1348 Review-Url: https://codereview.webrtc.org/3013623002 Cr-Commit-Position: refs/heads/master@{#19813} Committed: https://chromium.googlesource.com/external/webrtc/+/772bd8b6a7d232c94b1d2b1d37ec7e1f9515c7a7

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -36 lines) Patch
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_header_extension_map.h View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension_map.cc View 1 6 chunks +12 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 7 chunks +15 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_received.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
danilchap
Prefer to fix warnings instead of spreading them.
3 years, 3 months ago (2017-09-12 18:13:35 UTC) #10
eladalon
lgtm
3 years, 3 months ago (2017-09-13 09:12:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013623002/20001
3 years, 3 months ago (2017-09-13 10:21:44 UTC) #13
commit-bot: I haz the power
3 years, 3 months ago (2017-09-13 10:24:34 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/772bd8b6a7d232c94b1d2b1d3...

Powered by Google App Engine
This is Rietveld 408576698