Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 3 months ago by Taylor Brandstetter Modified:
3 years, 3 months ago Reviewers:
sakal CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd javadoc comment for PeerConnection.dispose.
Specifically calling out issue 3721 ("dispose can't be called from a
callback"), which developers frequently run into.
BUG=webrtc:3721
NOTRY=True
Review-Url: https://codereview.webrtc.org/3013573002
Cr-Commit-Position: refs/heads/master@{#19804}
Committed: https://chromium.googlesource.com/external/webrtc/+/43697f6da56c0c6eca8967a4fef57beb589d8990
Patch Set 1 #
Created: 3 years, 3 months ago
Messages
Total messages: 15 (10 generated)
Description was changed from ========== Add javadoc comment around PeerConnection.dispose. Specifically calling out issue 3721 (dispose can't be called from a callback), which developers frequently run into. BUG=None ========== to ========== Add javadoc comment around PeerConnection.dispose. Specifically calling out issue 3721 (dispose can't be called from a callback), which developers frequently run into: BUG=webrtc:3721 ==========
Description was changed from ========== Add javadoc comment around PeerConnection.dispose. Specifically calling out issue 3721 (dispose can't be called from a callback), which developers frequently run into: BUG=webrtc:3721 ========== to ========== Add javadoc comment for PeerConnection.dispose. Specifically calling out issue 3721 (dispose can't be called from a callback), which developers frequently run into: BUG=webrtc:3721 ==========
Description was changed from
==========
Add javadoc comment for PeerConnection.dispose.
Specifically calling out issue 3721 (dispose can't be called from a
callback), which developers frequently run into:
BUG=webrtc:3721
==========
to
==========
Add javadoc comment for PeerConnection.dispose.
Specifically calling out issue 3721 ("dispose can't be called from a
callback"), which developers frequently run into.
BUG=webrtc:3721
==========
deadbeef@webrtc.org changed reviewers: + sakal@webrtc.org
PTAL
lgtm
The CQ bit was checked by deadbeef@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by deadbeef@webrtc.org
Description was changed from
==========
Add javadoc comment for PeerConnection.dispose.
Specifically calling out issue 3721 ("dispose can't be called from a
callback"), which developers frequently run into.
BUG=webrtc:3721
==========
to
==========
Add javadoc comment for PeerConnection.dispose.
Specifically calling out issue 3721 ("dispose can't be called from a
callback"), which developers frequently run into.
BUG=webrtc:3721
NOTRY=True
==========
The CQ bit was checked by deadbeef@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1505238588249330, "parent_rev":
"e99738174344a7d172d9391f3bd9f485b9e64d67", "commit_rev":
"43697f6da56c0c6eca8967a4fef57beb589d8990"}
Message was sent while issue was closed.
Description was changed from
==========
Add javadoc comment for PeerConnection.dispose.
Specifically calling out issue 3721 ("dispose can't be called from a
callback"), which developers frequently run into.
BUG=webrtc:3721
NOTRY=True
==========
to
==========
Add javadoc comment for PeerConnection.dispose.
Specifically calling out issue 3721 ("dispose can't be called from a
callback"), which developers frequently run into.
BUG=webrtc:3721
NOTRY=True
Review-Url: https://codereview.webrtc.org/3013573002
Cr-Commit-Position: refs/heads/master@{#19804}
Committed:
https://chromium.googlesource.com/external/webrtc/+/43697f6da56c0c6eca8967a4f...
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/43697f6da56c0c6eca8967a4f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
