Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 3013573002: Add javadoc comment around PeerConnection.dispose. (Closed)

Created:
3 years, 3 months ago by Taylor Brandstetter
Modified:
3 years, 3 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add javadoc comment for PeerConnection.dispose. Specifically calling out issue 3721 ("dispose can't be called from a callback"), which developers frequently run into. BUG=webrtc:3721 NOTRY=True Review-Url: https://codereview.webrtc.org/3013573002 Cr-Commit-Position: refs/heads/master@{#19804} Committed: https://chromium.googlesource.com/external/webrtc/+/43697f6da56c0c6eca8967a4fef57beb589d8990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M webrtc/sdk/android/api/org/webrtc/PeerConnection.java View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Taylor Brandstetter
PTAL
3 years, 3 months ago (2017-09-12 00:29:36 UTC) #5
sakal
lgtm
3 years, 3 months ago (2017-09-12 07:11:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013573002/1
3 years, 3 months ago (2017-09-12 17:49:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013573002/1
3 years, 3 months ago (2017-09-12 17:49:53 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-09-12 17:52:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/43697f6da56c0c6eca8967a4f...

Powered by Google App Engine
This is Rietveld 408576698