Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 3013503002: Piggybacking simulcast id and ALR experiment id into video content type extension. Use it to slice … (Closed)

Created:
3 years, 3 months ago by ilnik
Modified:
3 years, 3 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), peah-webrtc, zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, fengyue_agora.io, kwiberg-webrtc, the sun, mflodman
Target Ref:
refs/branch-heads/62
Project:
webrtc
Visibility:
Public.

Description

Piggybacking simulcast id and ALR experiment id into video content type extension. Use it to slice UMA video receive statis. Merge into M62. Original was reviewed here: https://codereview.webrtc.org/2986893002 BUG=webrtc:8032, chromium:762867 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/2986893002 Cr-Original-Commit-Position: refs/heads/master@{#19598} (cherry picked from commit 6d5b4d6fe13951a7f3f6ed3d3b29bc601920e381) Review-Url: https://codereview.webrtc.org/3013503002 Cr-Commit-Position: refs/branch-heads/62@{#4} Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592} Committed: https://chromium.googlesource.com/external/webrtc/+/7f333377b8d7bda58cd262cd8d698d60347d7a3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -165 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/video/video_content_type.h View 1 chunk +14 lines, -1 line 0 comments Download
A webrtc/api/video/video_content_type.cc View 1 chunk +94 lines, -0 lines 0 comments Download
M webrtc/common_video/include/video_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/alr_detector.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/alr_detector.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/frame_buffer2_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.cc View 5 chunks +39 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/include/metrics.h View 3 chunks +49 lines, -18 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 4 chunks +15 lines, -9 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 4 chunks +23 lines, -11 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 15 chunks +213 lines, -85 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 9 chunks +116 lines, -23 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/video_stream_decoder.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/video/video_stream_decoder.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
ilnik
3 years, 3 months ago (2017-09-08 10:05:26 UTC) #3
tommi
lgtm
3 years, 3 months ago (2017-09-08 10:06:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013503002/1
3 years, 3 months ago (2017-09-08 10:10:50 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 3 months ago (2017-09-08 10:10:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013503002/1
3 years, 3 months ago (2017-09-08 10:12:10 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 10:12:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7f333377b8d7bda58cd262cd8...

Powered by Google App Engine
This is Rietveld 408576698