Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 3013033002: Remove VoEFile (Closed)

Created:
3 years, 3 months ago by the sun
Modified:
3 years, 3 months ago
Reviewers:
ossu, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoEFile and things it uses. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/3013033002 Cr-Commit-Position: refs/heads/master@{#19885} Committed: https://webrtc.googlesource.com/src/+/b63310a25690842a40b7cf31f1664d25831d0c70

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : better indentation #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3749 lines) Patch
M test/mock_voice_engine.h View 1 2 3 4 5 1 chunk +0 lines, -49 lines 0 comments Download
M voice_engine/BUILD.gn View 1 2 3 6 chunks +0 lines, -70 lines 0 comments Download
M voice_engine/channel.h View 1 2 3 11 chunks +0 lines, -73 lines 0 comments Download
M voice_engine/channel.cc View 1 2 3 11 chunks +1 line, -699 lines 0 comments Download
D voice_engine/coder.h View 1 2 3 1 chunk +0 lines, -68 lines 0 comments Download
D voice_engine/coder.cc View 1 2 3 1 chunk +0 lines, -118 lines 0 comments Download
D voice_engine/file_player.h View 1 2 3 1 chunk +0 lines, -80 lines 0 comments Download
D voice_engine/file_player.cc View 1 2 3 1 chunk +0 lines, -397 lines 0 comments Download
D voice_engine/file_player_unittests.cc View 1 2 3 1 chunk +0 lines, -115 lines 0 comments Download
D voice_engine/file_recorder.h View 1 2 3 1 chunk +0 lines, -57 lines 0 comments Download
D voice_engine/file_recorder.cc View 1 2 3 1 chunk +0 lines, -260 lines 0 comments Download
D voice_engine/include/voe_file.h View 1 2 3 1 chunk +0 lines, -144 lines 0 comments Download
M voice_engine/output_mixer.h View 1 2 3 6 chunks +1 line, -26 lines 0 comments Download
M voice_engine/output_mixer.cc View 1 2 3 7 chunks +1 line, -236 lines 0 comments Download
M voice_engine/transmit_mixer.h View 1 2 3 7 chunks +1 line, -67 lines 0 comments Download
M voice_engine/transmit_mixer.cc View 1 2 3 7 chunks +0 lines, -682 lines 0 comments Download
M voice_engine/utility.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M voice_engine/utility.cc View 1 2 3 1 chunk +0 lines, -36 lines 0 comments Download
M voice_engine/voe_base_impl.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
D voice_engine/voe_file_impl.h View 1 2 3 1 chunk +0 lines, -95 lines 0 comments Download
D voice_engine/voe_file_impl.cc View 1 2 3 1 chunk +0 lines, -466 lines 0 comments Download
M voice_engine/voice_engine_impl.h View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
the sun
3 years, 3 months ago (2017-09-14 12:38:26 UTC) #3
ossu
Oooh yes! I'd like to see it run through the bots first (including linux_internal) but ...
3 years, 3 months ago (2017-09-14 13:33:39 UTC) #4
ossu
lgtm då! :)
3 years, 3 months ago (2017-09-18 08:19:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013033002/100001
3 years, 3 months ago (2017-09-18 09:09:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21795)
3 years, 3 months ago (2017-09-18 09:15:27 UTC) #10
the sun
On 2017/09/18 09:15:27, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 3 months ago (2017-09-18 09:23:46 UTC) #12
kwiberg-webrtc
lgtm for //test/
3 years, 3 months ago (2017-09-18 09:25:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013033002/100001
3 years, 3 months ago (2017-09-18 09:29:17 UTC) #15
commit-bot: I haz the power
3 years, 3 months ago (2017-09-18 10:04:17 UTC) #18
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://webrtc.googlesource.com/src/+/b63310a25690842a40b7cf31f1664d25831d0c70

Powered by Google App Engine
This is Rietveld 408576698