Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 3013023004: Make rtp::Packet's destructor and constructors public (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make rtp::Packet's destructor and constructors public This will allow the RTP-related subclasses of RtcEvent keep an rtp::Packet for the header, rather than hold the heaver, and at the moment unnecessary for logging, RtpPacketReceived/RtpPacketToSend. BUG=webrtc:8111 Review-Url: https://codereview.webrtc.org/3013023004 Cr-Commit-Position: refs/heads/master@{#19812} Committed: https://chromium.googlesource.com/external/webrtc/+/87443ee3e69abf8dbf656952d29501daa248ff2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 2 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
eladalon
PTAL
3 years, 3 months ago (2017-09-13 08:47:01 UTC) #2
danilchap
lgtm
3 years, 3 months ago (2017-09-13 08:57:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013023004/1
3 years, 3 months ago (2017-09-13 08:59:24 UTC) #5
commit-bot: I haz the power
3 years, 3 months ago (2017-09-13 09:45:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/87443ee3e69abf8dbf656952d...

Powered by Google App Engine
This is Rietveld 408576698