Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 3013003002: Use hermetic toolchain on Mac, except for local iOS builds (Closed)

Created:
3 years, 3 months ago by oprypin_webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M .gn View 1 chunk +2 lines, -1 line 0 comments Download
M build_overrides/build.gni View 1 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
oprypin_webrtc
3 years, 3 months ago (2017-09-11 17:58:10 UTC) #5
kjellander_webrtc
lgtm and huge thanks for dealing with this mess.
3 years, 3 months ago (2017-09-11 18:04:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3013003002/20001
3 years, 3 months ago (2017-09-11 18:11:35 UTC) #10
commit-bot: I haz the power
3 years, 3 months ago (2017-09-11 18:38:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/370c6d5694dcf34005c335ceb...

Powered by Google App Engine
This is Rietveld 408576698