Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3012913002:
Add |RTCUIApplicationStatusObserver sharedInstance| call in ios test AppDelegate. (Closed)
|
Created:
3 years, 3 months ago by daniela-webrtc Modified:
3 years, 3 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd |RTCUIApplicationStatusObserver sharedInstance| call in ios test AppDelegate.
We want to perform the observation setup as soon as possible to avoid deadlocking,
especially for test scenario where most of the work is done on main thread.
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/3012913002
Cr-Commit-Position: refs/heads/master@{#19771}
Committed: https://chromium.googlesource.com/external/webrtc/+/d207a39d098259573f799aa5e6a1acff725b61a1
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add missing deps in build file #Patch Set 3 : Fix typo in class and documentation #
Messages
Total messages: 29 (20 generated)
The CQ bit was checked by denicija@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
denicija@webrtc.org changed reviewers: + andersc@webrtc.org, brandtr@webrtc.org
Please take a look
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...) ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/28102)
lgtm! https://codereview.webrtc.org/3012913002/diff/1/webrtc/test/ios/test_support.mm File webrtc/test/ios/test_support.mm (right): https://codereview.webrtc.org/3012913002/diff/1/webrtc/test/ios/test_support.... webrtc/test/ios/test_support.mm:65: // We want to call `RTCUIApplicationStatusObserver sharedInstance` as erly as typo: erly
My Objective-C++ is pretty weak, but this lgtm. (I guess the build error can be fixed by updating the BUILD file.)
The CQ bit was checked by denicija@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...) ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
The CQ bit was checked by denicija@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by denicija@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from andersc@webrtc.org, brandtr@webrtc.org Link to the patchset: https://codereview.webrtc.org/3012913002/#ps40001 (title: "Fix typo in class and documentation")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21442)
denicija@webrtc.org changed reviewers: + kjellander@webrtc.org
@Henrik can you please take a look as well. Thanks!
lgtm
The CQ bit was checked by denicija@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1505137246281220,
"parent_rev": "0ea0310b89a35e20072b3cad6712c46eba869228", "commit_rev":
"d207a39d098259573f799aa5e6a1acff725b61a1"}
Message was sent while issue was closed.
Description was changed from ========== Add |RTCUIApplicationStatusObserver sharedInstance| call in ios test AppDelegate. We want to perform the observation setup as soon as possible to avoid deadlocking, especially for test scenario where most of the work is done on main thread. BUG=webrtc:6634 ========== to ========== Add |RTCUIApplicationStatusObserver sharedInstance| call in ios test AppDelegate. We want to perform the observation setup as soon as possible to avoid deadlocking, especially for test scenario where most of the work is done on main thread. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3012913002 Cr-Commit-Position: refs/heads/master@{#19771} Committed: https://chromium.googlesource.com/external/webrtc/+/d207a39d098259573f799aa5e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/d207a39d098259573f799aa5e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
