Don't treat picture ids as wrapping in the FrameBuffer2 class.

Don't treat picture ids as wrapping in the FrameBuffer2 class.

Picture ids are now unwrapped in the RtpFrameReferenceFinder class, so the
FrameBuffer2 no longer need to treat them as wrapping.

BUG=webrtc:7874
Review-Url: https://codereview.webrtc.org/3012883002
Cr-Commit-Position: refs/heads/master@{#19779}
Committed: https://chromium.googlesource.com/external/webrtc/+/3b3c9c4eb03cb82373a978eb9c5b8c8c08cc7e27

[philipel, 2017-09-08 09:43:53]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org, terelius@webrtc.org

[philipel, 2017-09-08 09:43:54]

https://codereview.webrtc.org/3012883002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/sequence_number_util.h (right):

https://codereview.webrtc.org/3012883002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/sequence_number_util.h:98: static constexpr uint64_t
kDefaultStartValue = 1000000000000000000UL;
I removed one '0' to make the default value fit in a int64_t. More convenient...

[stefan-webrtc, 2017-09-11 16:00:33]

lgtm

[philipel, 2017-09-11 16:06:55]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2017-09-11 16:07:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-09-11 16:10:22]

https://codereview.webrtc.org/3012883002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/frame_buffer2.cc (right):

https://codereview.webrtc.org/3012883002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/frame_buffer2.cc:251: if (frame.picture_id < 0)
What does it mean if we get frame with negative picure_id? Can this even happen?

[commit-bot: I haz the power, 2017-09-11 16:38:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505146015195640,
"parent_rev": "423227306112c4011a538bf87ae7f2534f39f724", "commit_rev":
"3b3c9c4eb03cb82373a978eb9c5b8c8c08cc7e27"}

[commit-bot: I haz the power, 2017-09-11 16:38:41]

Description was changed from

==========
Don't treat picture ids as wrapping in the FrameBuffer2 class.

Picture ids are now unwrapped in the RtpFrameReferenceFinder class, so the
FrameBuffer2 no longer need to treat them as wrapping.

BUG=webrtc:7874
==========

to

==========
Don't treat picture ids as wrapping in the FrameBuffer2 class.

Picture ids are now unwrapped in the RtpFrameReferenceFinder class, so the
FrameBuffer2 no longer need to treat them as wrapping.

BUG=webrtc:7874

Review-Url: https://codereview.webrtc.org/3012883002
Cr-Commit-Position: refs/heads/master@{#19779}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3b3c9c4eb03cb82373a978eb9...
==========

[commit-bot: I haz the power, 2017-09-11 16:38:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/3b3c9c4eb03cb82373a978eb9...