Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 3012883002: Don't treat picture ids as wrapping in the FrameBuffer2 class. (Closed)

Created:
3 years, 3 months ago by philipel
Modified:
3 years, 3 months ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't treat picture ids as wrapping in the FrameBuffer2 class. Picture ids are now unwrapped in the RtpFrameReferenceFinder class, so the FrameBuffer2 no longer need to treat them as wrapping. BUG=webrtc:7874 Review-Url: https://codereview.webrtc.org/3012883002 Cr-Commit-Position: refs/heads/master@{#19779} Committed: https://chromium.googlesource.com/external/webrtc/+/3b3c9c4eb03cb82373a978eb9c5b8c8c08cc7e27

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M webrtc/modules/video_coding/frame_buffer2.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 1 chunk +5 lines, -1 line 1 comment Download
M webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/sequence_number_util.h View 1 1 chunk +5 lines, -5 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
philipel
https://codereview.webrtc.org/3012883002/diff/20001/webrtc/modules/video_coding/sequence_number_util.h File webrtc/modules/video_coding/sequence_number_util.h (right): https://codereview.webrtc.org/3012883002/diff/20001/webrtc/modules/video_coding/sequence_number_util.h#newcode98 webrtc/modules/video_coding/sequence_number_util.h:98: static constexpr uint64_t kDefaultStartValue = 1000000000000000000UL; I removed one ...
3 years, 3 months ago (2017-09-08 09:43:54 UTC) #2
stefan-webrtc
lgtm
3 years, 3 months ago (2017-09-11 16:00:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012883002/20001
3 years, 3 months ago (2017-09-11 16:07:05 UTC) #5
terelius
https://codereview.webrtc.org/3012883002/diff/20001/webrtc/modules/video_coding/frame_buffer2.cc File webrtc/modules/video_coding/frame_buffer2.cc (right): https://codereview.webrtc.org/3012883002/diff/20001/webrtc/modules/video_coding/frame_buffer2.cc#newcode251 webrtc/modules/video_coding/frame_buffer2.cc:251: if (frame.picture_id < 0) What does it mean if ...
3 years, 3 months ago (2017-09-11 16:10:22 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-11 16:38:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/3b3c9c4eb03cb82373a978eb9...

Powered by Google App Engine
This is Rietveld 408576698