Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 3012763002: Avoid construction of unused RtcEventLogNullImpl object (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Avoid construction of unused RtcEventLogNullImpl object This CL addresses to nits: 1. When event_log_factory_ is not null, there's no need to create a RtcEventLogNullImpl object. 2. Use MakeUnique. BUG=None Review-Url: https://codereview.webrtc.org/3012763002 Cr-Commit-Position: refs/heads/master@{#19686} Committed: https://chromium.googlesource.com/external/webrtc/+/393a9f6926636b94ec8accd5dfe4cd6e5c8ebafe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/pc/peerconnectionfactory.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
eladalon
PTAL
3 years, 3 months ago (2017-09-05 10:56:37 UTC) #2
stefan-webrtc
lgtm
3 years, 3 months ago (2017-09-05 10:58:38 UTC) #3
terelius
lgtm
3 years, 3 months ago (2017-09-05 10:58:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012763002/1
3 years, 3 months ago (2017-09-05 11:04:59 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-05 11:30:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/393a9f6926636b94ec8accd5d...

Powered by Google App Engine
This is Rietveld 408576698