Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
3012693002:
ObjC: Add null checks to HW encoder compressionOutputCallback (Closed)
|
Created:
3 years, 3 months ago by magjed_webrtc Modified:
3 years, 3 months ago Reviewers:
andersc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionObjC: Add null checks to HW encoder compressionOutputCallback
This will help debugging.
BUG=b/65254613
Review-Url: https://codereview.webrtc.org/3012693002
Cr-Commit-Position: refs/heads/master@{#19640}
Committed: https://chromium.googlesource.com/external/webrtc/+/85d18d43adc679d8d3160106a918fe05fdbc0755
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by magjed@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/27774) linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/25626)
Description was changed from ========== ObjC: Add null checks to HW encoder compressionOutputCallback BUG=b/65254613 ========== to ========== ObjC: Add null checks to HW encoder compressionOutputCallback BUG=b/65254613 ==========
magjed@webrtc.org changed reviewers: + andersc@webrtc.org
Description was changed from ========== ObjC: Add null checks to HW encoder compressionOutputCallback BUG=b/65254613 ========== to ========== ObjC: Add null checks to HW encoder compressionOutputCallback This will help debugging. BUG=b/65254613 ==========
Anders - please take a look.
On 2017/09/01 10:35:49, magjed_webrtc wrote: > Anders - please take a look. lgtm
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1504270821374020, "parent_rev":
"1acbd68718476b2754a7872fb72e3a8a74166eb9", "commit_rev":
"85d18d43adc679d8d3160106a918fe05fdbc0755"}
Message was sent while issue was closed.
Description was changed from ========== ObjC: Add null checks to HW encoder compressionOutputCallback This will help debugging. BUG=b/65254613 ========== to ========== ObjC: Add null checks to HW encoder compressionOutputCallback This will help debugging. BUG=b/65254613 Review-Url: https://codereview.webrtc.org/3012693002 Cr-Commit-Position: refs/heads/master@{#19640} Committed: https://chromium.googlesource.com/external/webrtc/+/85d18d43adc679d8d3160106a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/85d18d43adc679d8d3160106a... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
