Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 3012553002: Increased the allowed API call jitter in AEC3 (Closed)

Created:
3 years, 3 months ago by peah-webrtc
Modified:
3 years, 3 months ago
Reviewers:
aleloi
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increased the allowed API call jitter in AEC3 This CL increases the amount of API call jitter that is allowed in AEC3 without causing resets of AEC3. This increase is now possible, as non- causal alignments will be detected by the newly imposed delay bound. BUG=8175 Review-Url: https://codereview.webrtc.org/3012553002 Cr-Commit-Position: refs/heads/master@{#19603} Committed: https://chromium.googlesource.com/external/webrtc/+/cd8b079afb1859a7579cfc9a9fc8af3a2fef6673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_processing/aec3/aec3_common.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
peah-webrtc
Hi aleloi@ Could you please take a look at this CL?
3 years, 3 months ago (2017-08-29 23:00:02 UTC) #2
aleloi
lgtm
3 years, 3 months ago (2017-08-30 13:14:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012553002/1
3 years, 3 months ago (2017-08-30 13:17:12 UTC) #9
commit-bot: I haz the power
3 years, 3 months ago (2017-08-30 13:19:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/cd8b079afb1859a7579cfc9a9...

Powered by Google App Engine
This is Rietveld 408576698