Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 3012483002: Make DirectTransport::task_queue_ const (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make DirectTransport::task_queue_ const DirectTransport::task_queue_ previously could not be const, because of a hack for the deprecated version of DirectTransport. That is no longer the case. BUG=webrtc:8125 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/3012483002 Cr-Commit-Position: refs/heads/master@{#19583} Committed: https://chromium.googlesource.com/external/webrtc/+/8a6241e3511af461b64c3efa0e08ee031c7ca0c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M webrtc/test/direct_transport.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
eladalon
PTAL
3 years, 3 months ago (2017-08-29 11:50:50 UTC) #2
nisse-webrtc
lgtm
3 years, 3 months ago (2017-08-29 12:12:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012483002/1
3 years, 3 months ago (2017-08-29 12:43:23 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-08-29 13:53:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8a6241e3511af461b64c3efa0...

Powered by Google App Engine
This is Rietveld 408576698