ObjC: Add support for injectable native audio and video codecs

ObjC: Add support for injectable native audio and video codecs

The native interface is added in the private file
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Native.h.

BUG=webrtc:8093
Review-Url: https://codereview.webrtc.org/3012443002
Cr-Commit-Position: refs/heads/master@{#19576}
Committed: https://chromium.googlesource.com/external/webrtc/+/b8853ca8d351864a2396e0bdf677f61ad166a4b6

[magjed_webrtc, 2017-08-28 15:09:51]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2017-08-28 15:13:36]

Patchset #1 (id:20001) has been deleted

[magjed_webrtc, 2017-08-28 15:20:56]

Description was changed from

==========
ObjC: Add support for injectable native audio and video codecs

The native interface is added in the private file
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Native.h.

BUG=webrtc:8093
==========

to

==========
ObjC: Add support for injectable native audio and video codecs

The native interface is added in the private file
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Native.h.

BUG=webrtc:8093
==========

[magjed_webrtc, 2017-08-28 15:20:56]

magjed@webrtc.org changed reviewers:
+ denicija@webrtc.org, jeremyns@webrtc.org, kthelgason@webrtc.org,
tkchin@webrtc.org

[magjed_webrtc, 2017-08-28 15:21:35]

Please take a look.

We would have to revert
https://chromium-review.googlesource.com/c/external/webrtc/+/608981 before
landing this.

[magjed_webrtc, 2017-08-28 15:22:18]

magjed@webrtc.org changed reviewers:
+ andersc@webrtc.org

[tkchin_webrtc, 2017-08-28 23:16:52]

On 2017/08/28 15:21:35, magjed_webrtc wrote:
> Please take a look.
> 
> We would have to revert
> https://chromium-review.googlesource.com/c/external/webrtc/+/608981 before
> landing this.

lgtm

Jeremy can you take a look / stamp as well?

[magjed_webrtc, 2017-08-29 10:34:58]

On 2017/08/28 23:16:52, tkchin_webrtc wrote:
> On 2017/08/28 15:21:35, magjed_webrtc wrote:
> > Please take a look.
> > 
> > We would have to revert
> > https://chromium-review.googlesource.com/c/external/webrtc/+/608981 before
> > landing this.
> 
> lgtm
> 
> Jeremy can you take a look / stamp as well?

I'm going ahead and landing this.

[magjed_webrtc, 2017-08-29 10:35:04]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2017-08-29 10:35:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 10:57:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1504002904167820,
"parent_rev": "dad6198eeefe12de191a1287d24d2341ff3c0e82", "commit_rev":
"b8853ca8d351864a2396e0bdf677f61ad166a4b6"}

[commit-bot: I haz the power, 2017-08-29 10:57:30]

Description was changed from

==========
ObjC: Add support for injectable native audio and video codecs

The native interface is added in the private file
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Native.h.

BUG=webrtc:8093
==========

to

==========
ObjC: Add support for injectable native audio and video codecs

The native interface is added in the private file
webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Native.h.

BUG=webrtc:8093

Review-Url: https://codereview.webrtc.org/3012443002
Cr-Commit-Position: refs/heads/master@{#19576}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b8853ca8d351864a2396e0bdf...
==========

[commit-bot: I haz the power, 2017-08-29 10:57:31]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/b8853ca8d351864a2396e0bdf...

[mpotapov, 2017-08-29 12:41:11]

On 2017/08/28 15:21:35, magjed_webrtc wrote:
> Please take a look.

Do we have any reason to make Objective-C++ interfaces in WebRTC iOS SDK? I'm
asking because Swift doesn't have interoperability with C++ and all this code
doesn't compile in Swift projects.

[daniela-webrtc, 2017-08-29 13:21:12]

On 2017/08/29 12:41:11, mpotapov wrote:
> On 2017/08/28 15:21:35, magjed_webrtc wrote:
> > Please take a look.
> 
> Do we have any reason to make Objective-C++ interfaces in WebRTC iOS SDK? I'm
> asking because Swift doesn't have interoperability with C++ and all this code
> doesn't compile in Swift projects.

This SDK internally has plenty of Objc++ interfaces already.
However,  we want to keep the public headers pure ObjC and this CL is doing
exactly that.
So if you are using the WebRTC.framework you should have no problems with
integrating it in your project once again.