Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2249)

Issue 3012403002: Remove unnecessary send codec initialization from voe::Channel. (Closed)

Created:
3 years, 3 months ago by the sun
Modified:
3 years, 2 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unnecessary send codec initialization from voe::Channel. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/3012403002 Cr-Commit-Position: refs/heads/master@{#19981} Committed: https://webrtc.googlesource.com/src/+/6df16bf46d7d1983e9c7cca53b326ecf76454290

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M voice_engine/channel.cc View 1 2 2 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
the sun
3 years, 3 months ago (2017-09-18 14:33:22 UTC) #2
ossu
This looks fine by me, provided nothing still relies on these being defaults. I _think_ ...
3 years, 2 months ago (2017-09-25 16:54:00 UTC) #3
ossu
I've now completed the aforementioned spelunking and I can't find anywhere where this would cause ...
3 years, 2 months ago (2017-09-26 15:13:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012403002/40001
3 years, 2 months ago (2017-09-26 23:43:27 UTC) #11
commit-bot: I haz the power
3 years, 2 months ago (2017-09-27 00:13:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://webrtc.googlesource.com/src/+/6df16bf46d7d1983e9c7cca53b326ecf76454290

Powered by Google App Engine
This is Rietveld 408576698