Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 3012383002: Serialize "a=x-google-flag:conference". (Closed)

Created:
3 years, 3 months ago by Taylor Brandstetter
Modified:
3 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Serialize "a=x-google-flag:conference". There was a test for deserialization but not serialization. This was probably always broken and no one noticed. I only noticed while debugging something else. BUG=None TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/3012383002 Cr-Commit-Position: refs/heads/master@{#19875} Committed: https://webrtc.googlesource.com/src/+/d45aea8f42308060860f8c51dd56415a62d560c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M pc/webrtcsdp.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M pc/webrtcsdp_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Taylor Brandstetter
PTAL
3 years, 3 months ago (2017-09-16 07:56:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012383002/1
3 years, 3 months ago (2017-09-16 07:57:15 UTC) #5
commit-bot: I haz the power
3 years, 3 months ago (2017-09-16 08:24:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://webrtc.googlesource.com/src/+/d45aea8f42308060860f8c51dd56415a62d560c1

Powered by Google App Engine
This is Rietveld 408576698