Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 3012333003: Revert of Completed the functionalities of SrtpTransport. (Closed)

Created:
3 years, 3 months ago by sprang_webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Zach Stein
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Completed the functionalities of SrtpTransport. (patchset #7 id:320001 of https://codereview.webrtc.org/2997983002/ ) Reason for revert: This seems to be causing some video freezes. See https://bugs.chromium.org/p/webrtc/issues/detail?id=8251 Original issue's description: > Completed the functionalities of SrtpTransport. > > The SrtpTransport takes the SRTP responsibilities from the BaseChannel > and SrtpFilter. SrtpTransport is now responsible for setting the crypto > keys, protecting and unprotecting the packets. SrtpTransport doesn't know > if the keys are from SDES or DTLS handshake. > > BaseChannel is now only responsible setting the offer/answer for SDES > or extracting the key from DtlsTransport and configuring the > SrtpTransport. > > SrtpFilter is used by BaseChannel as a helper for SDES negotiation. > > BUG=webrtc:7013 > > Review-Url: https://codereview.webrtc.org/2997983002 > Cr-Commit-Position: refs/heads/master@{#19636} > Committed: https://chromium.googlesource.com/external/webrtc/+/e683c6871fef24d3ff64f085d6bc0e965f17fcf7 TBR=deadbeef@webrtc.org,pthatcher@google.com,zhihuang@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+931 lines, -1124 lines) Patch
M webrtc/p2p/base/fakepackettransport.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/pc/channel.h View 6 chunks +12 lines, -13 lines 0 comments Download
M webrtc/pc/channel.cc View 13 chunks +159 lines, -131 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 7 chunks +19 lines, -19 lines 0 comments Download
M webrtc/pc/rtptransport.h View 2 chunks +4 lines, -12 lines 0 comments Download
M webrtc/pc/rtptransport.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/pc/rtptransportinternal.h View 1 chunk +4 lines, -7 lines 0 comments Download
M webrtc/pc/srtpfilter.h View 4 chunks +79 lines, -26 lines 0 comments Download
M webrtc/pc/srtpfilter.cc View 6 chunks +298 lines, -78 lines 0 comments Download
M webrtc/pc/srtpfilter_unittest.cc View 16 chunks +303 lines, -31 lines 0 comments Download
M webrtc/pc/srtptransport.h View 4 chunks +10 lines, -100 lines 0 comments Download
M webrtc/pc/srtptransport.cc View 2 chunks +3 lines, -305 lines 0 comments Download
M webrtc/pc/srtptransport_unittest.cc View 1 chunk +40 lines, -386 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sprang_webrtc
Created Revert of Completed the functionalities of SrtpTransport.
3 years, 3 months ago (2017-09-15 08:53:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012333003/1
3 years, 3 months ago (2017-09-15 08:53:22 UTC) #3
commit-bot: I haz the power
3 years, 3 months ago (2017-09-15 08:56:33 UTC) #5
Try jobs failed on following builders:
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21687)

Powered by Google App Engine
This is Rietveld 408576698