Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 3012313002: Reject the descriptions that attempt to change the order of m= sections (Closed)

Created:
3 years, 3 months ago by Zhi Huang
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reject the descriptions that attempt to change the order of m= sections in current local description. When setting the descriptions, the order of m= sections would be compared against existing m= sections and an error would be returned if the order doesn't match. Related CL: https://codereview.webrtc.org/3015473002/ BUG=chromium:763842

Patch Set 1 #

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -25 lines) Patch
M webrtc/pc/peerconnectioninterface_unittest.cc View 1 2 chunks +34 lines, -0 lines 0 comments Download
M webrtc/pc/webrtcsession.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/pc/webrtcsession.cc View 1 3 chunks +40 lines, -19 lines 0 comments Download
M webrtc/pc/webrtcsession_unittest.cc View 5 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
Zhi Huang
PTAL. This is almost the same as CL https://codereview.webrtc.org/3015473002/ This CL is referring to master/head, ...
3 years, 3 months ago (2017-09-14 00:38:00 UTC) #5
Taylor Brandstetter
lgtm with nits (see https://codereview.webrtc.org/3015473002/)
3 years, 3 months ago (2017-09-14 00:42:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012313002/40001
3 years, 3 months ago (2017-09-14 05:47:51 UTC) #16
commit-bot: I haz the power
3 years, 3 months ago (2017-09-14 05:50:37 UTC) #21
Failed to commit the patch.

Powered by Google App Engine
This is Rietveld 408576698