Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 3012073002: Change reporting of timing frames conditions in GetStats on receive side (Closed)

Created:
3 years, 3 months ago by ilnik
Modified:
3 years, 3 months ago
Reviewers:
tommi, sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, kwiberg-webrtc, the sun, mflodman
Target Ref:
refs/branch-heads/62
Project:
webrtc
Visibility:
Public.

Description

Change reporting of timing frames conditions in GetStats on receive side Instead of the longest frame since the last GetStats call, the longest frame received during last 10 seconds should be returned in GetStats(). Previous way is not a good idea because there are maybe several consumers of GetStats calls. If not all of them parse timing frame reports, some of them may be lost. Also, streamline reporting of TimingFrames via GetStats (remove separate methods and use VideoReceiveStream::Stats struct instead). Merge into M62. Original reviewed here: https://codereview.webrtc.org/3008983002 BUG=webrtc:7594, chromium:762872 NOTRY=true NOPRESUBMIT=true TBR=sprang@webrtc.org Review-Url: https://codereview.webrtc.org/3012073002 Cr-Commit-Position: refs/branch-heads/62@{#6} Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592} Committed: https://chromium.googlesource.com/external/webrtc/+/625b4cccdb02c07405106ed7b312956dae9d003e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -56 lines) Patch
M webrtc/api/video/video_timing.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/api/video/video_timing.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M webrtc/call/video_receive_stream.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 3 chunks +5 lines, -18 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
ilnik
3 years, 3 months ago (2017-09-08 10:23:15 UTC) #2
tommi
lgtm
3 years, 3 months ago (2017-09-08 11:42:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012073002/1
3 years, 3 months ago (2017-09-08 12:27:11 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 12:27:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/625b4cccdb02c07405106ed7b...

Powered by Google App Engine
This is Rietveld 408576698